Skip to content

main fcl change - #951

Merged
aantonakis merged 4 commits into
production/sbnd-gen2from
BugFix/ADCScaleForBlips_Gen2Production
Nov 13, 2026
Merged

aantonakis merged 4 commits into
production/sbnd-gen2from
BugFix/ADCScaleForBlips_Gen2Production

Conversation

@Jjm321814

Copy link
Copy Markdown
Contributor

Copy of PR 939 #939 but aimed at production branch

@Jjm321814 Jjm321814 self-assigned this Jul 30, 2026
@Jjm321814
Jjm321814 requested a review from linyan-w July 30, 2026 14:45
@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Gen2 Production Jul 30, 2026
@aantonakis

Copy link
Copy Markdown
Contributor

Hi @linyan-w, just checking in to see if you able to review this PR? @Jjm321814 , maybe you can add reviewers from PR#939 as well since they already reviewed the develop version?

@Jjm321814

Copy link
Copy Markdown
Contributor Author

Ah sorry the other one has some feedback I need to address. I should be able to get these all ironed out next week

@aantonakis

Copy link
Copy Markdown
Contributor

No worries, thanks @Jjm321814 !

@linyan-w

linyan-w commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Hi yes! Once all the dev version PRs settles (this one still pending) we can merge. Thank you Alex and Jacob!

@Jjm321814

Copy link
Copy Markdown
Contributor Author

This PR should be ready now.

@aantonakis

Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_05 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_09

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@aantonakis

Copy link
Copy Markdown
Contributor

Hi @linyan-w, this PR passed the CI tests and should be ready to merge after your approval.

@aantonakis

Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@aantonakis

Copy link
Copy Markdown
Contributor

Hi @linyan-w , I think this is ready to be merged. Just checking in for a final review.

@linyan-w

Copy link
Copy Markdown
Contributor

Hi @linyan-w , I think this is ready to be merged. Just checking in for a final review.

yes sorry here we are!

@aantonakis

Copy link
Copy Markdown
Contributor

No worries, thanks @linyan-w !

@aantonakis
aantonakis merged commit 897e9c1 into production/sbnd-gen2 Nov 13, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting on Reviewer

Development

Successfully merging this pull request may close these issues.

4 participants