Repository navigation
main fcl change - #951
main fcl change#951
Conversation
|
Hi @linyan-w, just checking in to see if you able to review this PR? @Jjm321814 , maybe you can add reviewers from PR#939 as well since they already reviewed the develop version? |
|
Ah sorry the other one has some feedback I need to address. I should be able to get these all ironed out next week |
|
No worries, thanks @Jjm321814 ! |
|
Hi yes! Once all the dev version PRs settles (this one still pending) we can merge. Thank you Alex and Jacob! |
|
This PR should be ready now. |
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_05 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_09 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Hi @linyan-w, this PR passed the CI tests and should be ready to merge after your approval. |
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Hi @linyan-w , I think this is ready to be merged. Just checking in for a final review. |
yes sorry here we are! |
|
No worries, thanks @linyan-w ! |
Copy of PR 939 #939 but aimed at production branch