Skip to content

extending blip PSTAR-based energy reco spline upper limit to 200 MeV from 20 MeV - #963

Open
sungbinoh wants to merge 3 commits into
SBNSoftware:developfrom
sungbinoh:feature/sungbino_blip_pstar_extend
Open

sungbinoh wants to merge 3 commits into
SBNSoftware:developfrom
sungbinoh:feature/sungbino_blip_pstar_extend

Conversation

@sungbinoh

@sungbinoh sungbinoh commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Description

Updating blip energy reconstruction for protons.
Extending the energy range for the PSTAR-based energy reconstruction spline from 20 MeV to 200 MeV.

Please note a caveat. The representative dE/dx for the recombination factor calculation is estimated using the total length (CSDA) and the initial energy found in the PSTAR table. This is a choice made to convert total charge of a blip to the energy, rather than using each hit's information.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{blue}\bf{\textrm{IMPORTANT UPDATE Feb 2nd 2026:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production for gen 2 SBND analyses, you must make two PRs: one for develop and one for the production/sbnd-gen2 branch.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or tjones79) as additional reviewer.
    No
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Duplicating PR#964 for the gen2.

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

No

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

  • Using the code in sbn-docdb-40570 for spline production.

  • The low energy proton blip energy reconstruction issue coming from too low energy upper limit for the splline production is covered in sbn-docdb-49314.

@@ -1,4 +1,4 @@
#include "sbndcode/BlipRecoSBND/Alg/BlipRecoAlg.h"
g#include "sbndcode/BlipRecoSBND/Alg/BlipRecoAlg.h"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same typo as the other PR here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Fixed it!

@linyan-w
linyan-w requested review from linyan-w and removed request for linyan-w October 7, 2026 12:52
@aantonakis

Copy link
Copy Markdown
Contributor

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_23_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_23_00

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@sungbinoh

Copy link
Copy Markdown
Contributor Author

Hi @Jjm321814, could you please have a look at this PR and approve it if it looks good to you? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reco1/reco2 Reconstruction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants