Repository navigation
Conversation
| @@ -1,4 +1,4 @@ | |||
| #include "sbndcode/BlipRecoSBND/Alg/BlipRecoAlg.h" | |||
| g#include "sbndcode/BlipRecoSBND/Alg/BlipRecoAlg.h" | |||
There was a problem hiding this comment.
Same typo as the other PR here
There was a problem hiding this comment.
Thank you. Fixed it!
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_23_00 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_23_00 |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Hi @Jjm321814, could you please have a look at this PR and approve it if it looks good to you? Thank you! |
Description
Updating blip energy reconstruction for protons.
Extending the energy range for the PSTAR-based energy reconstruction spline from 20 MeV to 200 MeV.
Please note a caveat. The representative dE/dx for the recombination factor calculation is estimated using the total length (CSDA) and the initial energy found in the PSTAR table. This is a choice made to convert total charge of a blip to the energy, rather than using each hit's information.
Checklist
Reviewers,AssigneesDevelopementNo
Duplicating PR#964 for the gen2.
Relevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
No
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?
Using the code in sbn-docdb-40570 for spline production.
The low energy proton blip energy reconstruction issue coming from too low energy upper limit for the splline production is covered in sbn-docdb-49314.