Repository navigation
[Gen2] Pandora DENT tune - #972
Conversation
There was a problem hiding this comment.
Comments from the SBND cathode-crossing stitching tests (the 133-layer window from #971 and the y-z fallback in larpandoracontent).
What matches our tested setup. The Master XML stitching block is the same as the one we ran: both passes with HalfWindowLayers 133, MinLongitudinalDisplacementX -4.0 (3D pass) and -5.0 (y-z pass), LooserMaxTransverseDisplacement 4.0, and the same InTimeMaxX0 and LArCrossGapsAssociation settings.
What differs from our tested setup
- Cosmic and Neutrino XMLs. Our tested XMLs also have the worker-instance
LArPfoStitchingblock inPandoraSettings_Cosmic_SBND.xmlandPandoraSettings_Neutrino_SBND.xml(ThreeDStitchingModetrue,AlwaysApplyT0Calculationfalse,OnlyFinalStatePfosfalse, -4.0 / 4.0), which needs the stitching-in-workers changes (larpandoracontent#99). This PR only changes the Master XML, so it is the Master-only subset of what we measured. Our numbers (36 of 95 near-parallel and 4 of 60 steep broken crossings rejoined, 0 of 60 good stitches lost) were for the full setup, so I would not quote them for this PR without a rerun. - y-z fallback. The tested builds had the
GetClosestVerticesy-z fallback always on, in every stitching tool. It is now opt-in, so it needs the XML line suggested inline below, plus the change from larpandoracontent#106 in the release (it would need adding to #99). Without that change the tag is ignored silently.
Suggested check. Rerun reco2 on the 215 target events with the gen2 special build, this XML and the flag. We expect about 6 of 95 near-parallel crossings rejoined from the fallback and more from the window, with no good stitches lost.
|
I am checking out this, rebuilding it, testing it against my step up just to make sure it works -- Alex you're more of an expert of "Master" vs. "Cosmic"/"Neutrino" xmls, let me know if that's a red-herring on slack |
|
I finished my checks and they passed, so once Alex adds the new flag in I think this is ready to ship! |
Co-authored-by: jzennamo <jzennamo@gmail.com>
|
Thanks! This looks good now, once a special larpandoracontent tag has been made (ready in this PR 99, I will update the xml again to include the stitching in the Neutrino, Cosmic, and Slicing worker instances. |
|
Hi @AlexWilkinsonnn and @jzennamo, I just wanted to check in on the status of this PR. We have this PR listed as being part of the gen2 respin and I believe we are trying to get a new gen2 release for this by the end of this week. Do you think this PR will be ready on this timescale? Thanks! |
linyan-w
left a comment
There was a problem hiding this comment.
I think this is ready now that we have the new larpandoracontent in a tagged larsoft.
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_05 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_09 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Hi @aantonakis , yes this PR is ready. Currently, it does not depend on the new patch of larsoft ( |
|
commit 6df1983 is the last pandora DENT tune update, it requires larsoft patch |
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_05 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_09 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_05 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_09 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
Hi @AlexWilkinsonnn, @jzennamo and @linyan-w. We had some issues with the CI recently but It's now working and I just got it to run on this PR. The latest CI output shows differences in product sizes but I think this is expected given the nature of this PR. I just wanted to check with all of you before merging. Thanks! |
|
Hi @aantonakis . Thanks for running the CI! Looking at some of the stdout, I see stuff like and then Pandora throwing an error code. So some of the new updates are not being applied. It looks like the CI is being run with larsoft We would expect the product sizes to change with this PR though, likely slightly less PFParticle objects. |
|
thanks for the clarification @AlexWilkinsonnn. My guess is that Herb will update the sbncode larsoft dependency to v10_14_02_06 in the next sbncode release and then I can rerun the CI with that new sbncode once it's out. |
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
trigger build ci_ref=v10_14_02_09 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_06 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_10 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
Combines the updates in PR #933 and PR #971 for the gen2 production tag. These are all the pandora tunes we can do without requiring a new special release of larpandoracontent.