Skip to content

Bugfix/acastill ophitfinder database - #978

Open
asanchezcastillo wants to merge 1 commit into
developfrom
bugfix/acastill_ophitfinder_database
Open

asanchezcastillo wants to merge 1 commit into
developfrom
bugfix/acastill_ophitfinder_database

Conversation

@asanchezcastillo

Copy link
Copy Markdown
Contributor

Description

This PR removes the ChannelMask parameter on the ophitfinder. Instead, the channels to be reconstructed are taken from the calibration database, to avoid inconsistencies.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{blue}\bf{\textrm{IMPORTANT UPDATE Feb 2nd 2026:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production for gen 2 SBND analyses, you must make two PRs: one for develop and one for the production/sbnd-gen2 branch.

$${\color{blue}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or tjones79) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@asanchezcastillo
asanchezcastillo force-pushed the bugfix/acastill_ophitfinder_database branch from 944f40c to 66f504a Compare October 28, 2026 11:10
@linyan-w linyan-w moved this to Waiting on Reviewer in SBND 2025 Gen2 Production Nov 9, 2026

@tbwester tbwester left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for adding this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting on Reviewer

Development

Successfully merging this pull request may close these issues.

2 participants