Repository navigation
Conversation
sliceWaveforms took the full-readout std::vector<raw::OpDetWaveform> (and the PMT channel list) by value, so every event copied all waveforms before slicing them: 432 MB in a BNB + cosmics detsim job, on top of the originals. Both arguments are only read; they are now const references. No change in output; the detsim peak memory is set inside WireCell, so it does not move. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opDetDigitizerSBND::sliceWaveformstook the full-readout waveform vector and the PMT channel list by value, copying every PMT waveform (432 MB per event in a BNB + cosmics job). Both are only read, so they are now const references.Measured effect: Removes a 432 MB transient copy per event. The detsim job's peak memory did not change, because the peak is set inside WireCell.
Validation: No change in output (the function body is unchanged).
Context: one item of a menu of time, memory, and disk savings for the Gen3 MC production. Each change is its own PR with one commit on develop, so they can be taken (or not) independently. Profiling and validation are in the slides "Gen3 MC Production: Where the Time and Disk Go" (Nov 2026). The validation is a fixed-seed comparison of the full gen-to-CAF chain against v10_26_00 (124 events, release run twice to measure its own run-to-run variation), plus each change applied alone on the release's own inputs and compared in the flat CAF (2895 branches).
🤖 Generated with Claude Code