Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

Add possibility to set smartling.client_lib_id directive value and send it to Smartling #8

Open

Description

@dimitrystd

DoD:

  • Add the new property clientUid to SDK
  • New property is optional and must have default value
    • Default value must contain name of lib + version
    • Exact format of strings {"client":"smartling-api-sdk-ruby","version":"1.0.0" }
  • SDK must add smartling.client_lib_id directive to all Upload request into request params (not a file body)

Example of implementation in java sdk

Activity

  1. foo4u commented on Nov 1, 2016

    @foo4u
    Contributor

    @dimitrystd in what form would this render on requests, the user agent, some custom header?

  2. self-assigned this
    on Nov 1, 2016
  3. dimitrystd commented on Nov 1, 2016

    @dimitrystd
    ContributorAuthor

    Actually there is 2 separate tasks:

    Each one is used for different cases. Smartling directive is saved in content_files table and can be used in looker reports (we have couple of them). But it works only for uploads requests. That the reason why we added to user-agent, to track other activities (check status; downloads). In this case it's possible to use splunk.

  4. amadatimvu commented on Oct 13, 2017

    @amadatimvu

    facing issue importing smartling:
    require "smartling_xcode"
    require "smartling"

    ': [!] Exit status of command 'cd ..; s/l10n push' was 1 instead of 0. (FastlaneCore::Interface::FastlaneShellError)
    s/l10n:3:in require': cannot load such file -- smartling_xcode (LoadError) from s/l10n:3:in

    '

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions