Skip to content

avoid the array (multi-bulk) allocation in sentinel processors - #1491

Merged
mgravell merged 2 commits into
masterfrom
zero-alloc-array-parse
Jun 8, 2020
Merged

avoid the array (multi-bulk) allocation in sentinel processors#1491
mgravell merged 2 commits into
masterfrom
zero-alloc-array-parse

Conversation

@mgravell

@mgravell mgravell commented Jun 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • uses GetItems() which provides access to the raw tokenized stream data, without any allocations, instead of GetItemsAsValues() which creates a RedisValue[] of copies
  • generalizes the existing StreamInfoKeys (which is what used this first) to KeyValuePairParser

@mgravell
mgravell requested a review from NickCraver June 8, 2020 14:19
NickCraver
NickCraver approved these changes Jun 8, 2020
View reviewed changes

@NickCraver NickCraver left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mgravell
mgravell merged commit 39781a7 into master Jun 8, 2020
@NickCraver
NickCraver deleted the zero-alloc-array-parse branch June 21, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCraver NickCraver NickCraver approved these changes

Assignees

No one assigned

Labels

🐌 performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgravell @NickCraver