Add i18n toggle button (en & zh-hans)#400
Conversation
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
| "@sentry/react": "^8.35.0", | ||
| "@sentry/vite-plugin": "^2.22.6", | ||
| "@tailwindcss/typography": "^0.5.13", | ||
| "@tanstack-dev/components": "^1.4.0", |
There was a problem hiding this comment.
I don't think it would be a good idea to install a 3rd party dependency like this. This component should just live in this codebase.
|
How do the translations work? Where do they come from? Where do they live? |
|
I see that this PR is actually suggesting to redirect to a translated mirror on tanstack.com. While the effort is appreciated, and we do want to offer the tanstack docs in other languages, I think we need to figure out a way to do an AI translate in our build pipelines in a way in which is not too expensive. Otherwise, our ever evolving docs will get out of date in the mirrors. I almost think that it's more important for docs to be up to date than translated, as there are already browser tools that can translate our real most up to date docs, at least. |
|
Hi, I’m a developer from Korea currently using TanStack Query and TanStack Router. In Korea, many developers are already using TanStack’s excellent libraries, and there are Korean-translated versions of the documentation created to support learning through the official docs. (query, router) I’m very interested in contributing to this effort and wanted to ask if you have any plans to officially support translations of TanStack’s documentation into multiple languages. |
In this PR, we add translate redirect ability.
app/routes/_libraries/route.tsx&app/components/DocsLayout.tsx)The current translate button supports two languages: english (https://tanstack.com/) & zh-Hans (https://zh-hans.tanstack.dev/)
Here are some screenshots: