Draft
Make symbolName required in reportLikelyUnsafeImportRequiredError, use symbolName() utility#11
symbolName required in reportLikelyUnsafeImportRequiredError, use symbolName() utility#11Conversation
Co-authored-by: arcanis <1037931+arcanis@users.noreply.github.com>
Co-authored-by: arcanis <1037931+arcanis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update TS2742 error to include symbol name
Include symbol name in TS2742 error when available from symbolToTypeNode
Feb 27, 2026
…ithout symbol name Co-authored-by: arcanis <1037931+arcanis@users.noreply.github.com>
Copilot
AI
changed the title
Include symbol name in TS2742 error when available from symbolToTypeNode
Include symbol name in TS2742 error message
Feb 27, 2026
Co-authored-by: arcanis <1037931+arcanis@users.noreply.github.com>
Copilot
AI
changed the title
Include symbol name in TS2742 error message
Reuse TS2742 for unsafe import error; make symbolName required
Feb 27, 2026
…l.escapedName) Co-authored-by: arcanis <1037931+arcanis@users.noreply.github.com>
Copilot
AI
changed the title
Reuse TS2742 for unsafe import error; make symbolName required
Make Feb 27, 2026
symbolName required in reportLikelyUnsafeImportRequiredError, use symbolName() utility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reportLikelyUnsafeImportRequiredErroracceptedsymbolName?: string, but the implementation usedsymbolName ?? specifier— meaningundefinedwould silently produce wrong diagnostic output. The parameter should be required since the function is meaningless without it.types.ts:SymbolTracker.reportLikelyUnsafeImportRequiredError—symbolName?: string→symbolName: stringchecker.ts: Both call sites now usesymbolName()utility instead ofunescapeLeadingUnderscores(symbol.escapedName);getModuleSpecifierOverridecall site guards onnodeSymboltruthiness before callingchecker.ts(SymbolTrackerImpl): Signature updated to match interfacedeclarations.ts: Signature updated, removed?? specifierfallback💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.