Skip to content

Code title displayed in HTML #18

Closed

Description

@gdolle

Hi @azu,

It seems that currently in Gitbook, the parser displays the html code in the title (see generateEmbedCode )

for example, we see this <a name="test.js" href="fixtures/test.js">test.js</a> instead of [test.js](fixtures/test.js).

It looks like a bug right ?

Activity

  1. gdolle commented on May 4, 2016

    @gdolle
    ContributorAuthor

    I think that it might be a good idea to make the title optional in the future.

    For example:

    • [import, title:example](path/to/file.js) results to

    example

    // source code
    

    • [import, title](path/to/file.js) results to

    file.js

    // source code
    

    What do you think ? (If you're ok, I open a specific issue)

  2. azu commented on May 4, 2016

    @azu
    Owner

    @gdolle

    we see this <a name="test.js" href="fixtures/test.js">test.js</a> instead of [test.js](fixtures/test.js).

    It is expected behavitor.
    At first, the motivation of <a name> is used for anker link.( <a href="#test.js">Anker Link</a>. Markdown have not the same feature of name)

    If we introduced pluginsConfig like "embed-template", this issue and #7 will be resolved, I think.


    make the title optional in the future.
    -- #18 (comment)

    title: command/attribute? is good idea.

    What do you think ? (If you're ok, I open a specific issue)

    Ok. It will be separated issue.

  3. gdolle commented on May 4, 2016

    @gdolle
    ContributorAuthor

    It is expected behavitor.
    At first, the motivation of is used for anker link.( <a href="#test.js">Anker Link</a>. Markdown have not the same feature of name)

    @azu Ok. After a second check, it seems that the problem comes from the asciidoc format that does not display properly the html code. In markdown everything is ok.

  4. added 2 commits that reference this issue on May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions