Highlight bug in language-detection for C++ codes #21

Activity

1. azu commented on May 8, 2016

   

   azu

   on May 8, 2016

   Last edited by azu

   Owner

   More actions

   Intesting.
   https://github.com/blakeembrey/language-map/blob/b72edb8c2cb1b05d098782aa85dd2f573ed96ba3/languages.json#L431-L455 defined that the aceMode of .cpp file is c_cpp.

   • gitbook-plugin-include-codeblock/src/language-detection.js

     Lines 26 to 45 in e1efa58

     	export function lookupLanguageByExtension(ext) {
     	let aceMode;
     	Object.keys(language_map).some(langKey => {
     	const extensions = language_map[langKey]["extensions"];
     	/* TODO: These lang has not extensions
     	Ant Build System
     	Isabelle ROOT
     	Maven POMAnt Build System
     	*/
     	if (!extensions) {
     	return false;
     	}
     	return extensions.some(extension => {
     	if (ext === extension) {
     	aceMode = language_map[langKey]["aceMode"];
     	}
     	});
     	});
     	return aceMode;
     	}

     look up the aceMode.

   Which is correct value aliases or searchTerm?
   I don't know correct way...
2. azu

   added

   bug

   on May 8, 2016
3. gdolle commented on May 8, 2016

   

   gdolle

   on May 8, 2016

   Last edited by gdolle

   ContributorAuthor

   More actions

   It should be cpp so one or another seems ok :)
4. gdolle commented on May 8, 2016

   

   gdolle

   on May 8, 2016

   Last edited by gdolle

   ContributorAuthor

   More actions

   Hum actually, I maybe replied too fast.
   I'm not sure that aliases or searchTerm are better than aceMode if we look at the map for other languages.

   Maybe we could just add a specific test for c++, and parse (remove) the lang like /c_cpp/cpp/g.

   What do you think ?
5. azu commented on May 8, 2016

   

   azu

   on May 8, 2016

   Owner

   More actions

   We use Linguist to perform language detection and syntax highlighting. You can find out which keywords are valid in the languages YAML file.

   via Creating and highlighting code blocks - User Documentation

   Maybe, correct algorithm is defined in github/linguist.
6. azu commented on May 8, 2016

   

   azu

   on May 8, 2016

   Owner

   More actions

   Maybe we could just add a specific test for c++, and parse (remove) the lang like /c_cpp/cpp/g.

   I want to avoid special case, but it is simple solution.
   I agree with @gdolle's suggestion that does /c_cpp/cpp/g.
7. gdolle commented on May 8, 2016

   

   gdolle

   on May 8, 2016

   ContributorAuthor

   More actions

   I agree with you @azu that it is just a workaround, it would be better to check github/linguist.
   It seems that currently, highlight.js is used with gitbook
8. azu

   added

   Braking Change

   on May 9, 2016
9. gdolle

   added a commit that references this issue on Jan 5, 2017

   Update issue azu#21

   ...

   423851e
10. azu

    added a commit that references this issue on Jan 6, 2017

    Fix issue #33, update #21 (#37)

    ...

    c916292
11. azu commented on Jan 6, 2017

    

    azu

    on Jan 6, 2017

    Owner

    More actions

    This is resolved by 2.2.0 and close it
12. azu

    closed this as completedon Jan 6, 2017