Repository navigation
hci: fix LE_SET_PHY phy_options size - #507
Merged
Merged
Conversation
Member
|
Thanks for fixing this. |
mringwal
pushed a commit
that referenced
this pull request
Jul 21, 2023
Co-authored-by: Andrey Fominykh <afominykh@topcon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When sending HCI_LE_SET_PHY command controller responds with 'Unsupported Feature or Parameter Value (0x11)'. Wireshark is also complaining about the command structure
According to BLUETOOTH CORE SPECIFICATION Version 5.2 | Vol 4, Part E 7.8.49 LE Set PHY command PHY_Options field has 2 octets
How to reproduce : you may use e.g. gap_le_set_phy to send the command, e.g. in handling HCI_SUBEVENT_LE_CONNECTION_COMPLETE event. Then collect the packet log and analyze.
Fix: correct PHY_Options size
*How to verify: redo the test and check the command status