Repository navigation
Explicitly default copying for polymorphic option types - #162
Open
trestoncuzzort wants to merge 1 commit into
Open
trestoncuzzort wants to merge 1 commit into
trestoncuzzort wants to merge 1 commit into
Conversation
Retain existing destructors and copy behavior while avoiding deprecated implicit-copy diagnostics for exception classes and abstract_variables_map. Test exception payloads and variables-map copy/move destinations through static and shared builds. Fixes boostorg#146. Fixes boostorg#147. Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #146 and #147.
With
-Werror=deprecated-copy-with-dtor, copying avariables_map, returning one by value, or creating a typed option can fail to compile. The implicit copies are deprecated because the relevant polymorphic classes declare destructors.Explicitly default copy construction and assignment in
abstract_variables_mapand the exception classes that declare destructors. Retain the destructors and existing memberwise copy behavior, including the non-owning next-map link and copy fallback for exception rvalues.Add one regression through both static and shared test targets. On Clang versions supporting the diagnostic, it promotes the warning to an error. Runtime checks cover exception messages, context, kinds, alternatives and config tokens; map fallback links, required options, final values, composing vectors, notifier lifetime, and copy/move destinations.
Validation:
copymodule; source and assertions are unchanged.Implemented and tested with Codex assistance; every changed line was self-reviewed.