Skip to content

bug: the manifestPath should always be set when using a git remote #73

Closed
#74
Closed
bug: the manifestPath should always be set when using a git remote#73
#74

Description

@mmalenic
mmalenic
opened on Feb 19, 2025

The line that sets the manifestPath when using a git remote should be pulled outside of this if branch otherwise the manifestPath is not correctly set when using a cached git clone:

cargo-lambda-cdk/src/cargo.ts

Lines 53 to 70 in 91d5dd6

if (!existsSync(localPath)) {
mkdirSync(localPath, { recursive: true });
const args = ['clone'];
if (gitReference === 'HEAD') {
args.push('--depth', '1');
}
args.push(project.gitRemote, localPath);
exec('git', args);
if (gitReference !== 'HEAD') {
exec('git', ['checkout', gitReference], { cwd: localPath });
}
// Append Cargo.toml to the path
manifestPath = join(localPath, defaultManifestPath);
}

Activity

  1. calavera
    closed this as completedin #74on Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions