Skip to content

fix: performance tweak. - #14

Merged
dirtybits merged 1 commit into
developmentfrom
unknown repository
Sep 4, 2019
Merged

dirtybits merged 1 commit into
developmentfrom
unknown repository

Conversation

@n8tb1t

@n8tb1t n8tb1t commented Sep 3, 2019

Copy link
Copy Markdown
Contributor

Thanks to: https://github.com/bobbieltd/derogold/commit/81f11906fc78116c442c402b6fa827ec5ce0509a

  • Exchanges will delist or refuse to list small coins if this shit keeps to be applied
  • No impact on performance (even quicker better on low end hardware nodes)

256 Mb write is enough.
Read buffer is unimportant (it shares with OS cache).
Opening files : few hundreds is enough.
Back threads 4 (well 4 cores already enough)
The original dev put 10 Mb (he was not stupid because it is idiot to put big number there)
Turtle dev applied that commit in hurry without much consideration
From outside dev
Background threads = 10 —> assumption people run CPU with 16 cores or what ? Normally,
daemon won’t use many threads but in the worst scenario it will use 10 cores
Those config numbers are for worst case.
In normal circumstances, daemon utilizes less.

Thanks to: https://github.com/bobbieltd/derogold/commit/81f11906fc78116c442c402b6fa827ec5ce0509a
- Exchanges will delist or refuse to list small coins if this shit keeps to be applied
- No impact on performance (even quicker better on low end hardware nodes)

256 Mb write is enough. 
Read buffer is unimportant (it shares with OS cache). 
Opening files : few hundreds is enough. 
Back threads 4 (well 4 cores already enough)
The original dev put 10 Mb (he was not stupid because it is idiot to put big number there)
Turtle dev applied that commit in hurry without much consideration
From outside dev
Background threads = 10 —> assumption people run CPU with 16 cores or what ? Normally,
daemon won’t use many threads but in the worst scenario it will use 10 cores
Those config numbers are for worst case. 
In normal circumstances, daemon utilizes less.
@DevMiner2

Copy link
Copy Markdown

128 open files should be plenty for a daemon with a network of this size. It will need to fetch more files in the long run which degrades performance a bit but it will be worth the benefits, which would be:

  • Faster startup
  • Even better performance on systems with relatively low I/O performance (Raspberries Pis, old laptops, etc.)
  • Faster close times due to files already being written to disk

@dirtybits
dirtybits merged commit 980ac2f into catalystdevelopment:development Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants