Expose ssl_select_cert_disable_ech#479
Open
sharrington22 wants to merge 1 commit intocloudflare:masterfrom
Open
Expose ssl_select_cert_disable_ech#479sharrington22 wants to merge 1 commit intocloudflare:masterfrom
sharrington22 wants to merge 1 commit intocloudflare:masterfrom
Conversation
ghedo
requested changes
Mar 10, 2026
Member
ghedo
left a comment
There was a problem hiding this comment.
Added a few minor comments, lgtm otherwise.
| /// A fatal error to be returned from async select certificate callbacks. | ||
| #[derive(Debug, Copy, Clone, PartialEq, Eq)] | ||
| pub struct AsyncSelectCertError; | ||
| pub enum AsyncSelectCertError { |
Member
There was a problem hiding this comment.
This isn't really an "error" anymore, and since we are changing the type anyway we might as well rename it as well. Maybe "AsyncSelectCertResult" or "AsyncSelectCertAction" or something along those lines.
| @@ -230,7 +237,12 @@ where | |||
|
|
|||
| /// A fatal error to be returned from async select certificate callbacks. | |||
Member
There was a problem hiding this comment.
This also needs to be updated to reflect the fact that it's not really a fatal error anymore.
| /// A fatal error to be returned from async select certificate callbacks. | ||
| #[derive(Debug, Copy, Clone, PartialEq, Eq)] | ||
| pub struct AsyncSelectCertError; | ||
| pub enum AsyncSelectCertError { |
Member
There was a problem hiding this comment.
We could also maybe make this enum non_exhaustive so future changes won't break API, but not 100% sure that makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssl_select_cert_disable_echshould be returned by the certificate selection callback when it wants ECH fallback to occur (falling back from the inner client hello to the outer client hello). This exposes it for both the sync and the async callback paths.