Repository navigation
NamedNodeMap check causes Firefox Gecko <34 to crash #65
Description
Activity
Any word on this? Should be a direct swap out of the line. We still have number non-trivial number of folks that can't our web app because of this
Thanks for getting to this; seems that the fix isn't complete though.
You still need the typeof check in both if blocks (original post) to prevent attempted evaluation of NamedNodeMap object crashing the webpage.
Do give it a test run in a Mozilla browser pre 34 to reproduce the behavior: https://ftp.mozilla.org/pub/firefox/releases/33.1/
Hi
The fix was verified on Firefox 33 before the merge.
Since we haven't published a release yet, you'll have to adjust your bower.json to install the fixed version manually:Replace
"cloudinary_ng": "~1.0.0"with"cloudinary_ng": "#c7301f0"in yourbower.jsonand runbower installto get the latest code.Let me know if it works for you.
- Ah, I didn't see that it wasn't merged. I'll give it a go. Thank you!…On Tue, Jan 17, 2017 at 2:48 AM, Eitan Peer ***@***.***> wrote: Hi The fix was verified on Firefox 33 before the merge. Since we haven't published a release yet, you'll have to adjust your bower.json to install the fixed version manually: Replace "cloudinary_ng": "~1.0.0" with "cloudinary_ng": "#c7301f0" in your bower.json and run bower install to get the latest code. Let me know if it works for you. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACntcOHQ_-_ndFxByYlCmR9DOnF2h1dnks5rTJyXgaJpZM4LdKJ5> .
- Just confirmed using the commit tag. thanks again for following up and making the fix!…On Tue, Jan 17, 2017 at 9:01 AM, Samir Chugh ***@***.***> wrote: Ah, I didn't see that it wasn't merged. I'll give it a go. Thank you! On Tue, Jan 17, 2017 at 2:48 AM, Eitan Peer ***@***.***> wrote: > Hi > > The fix was verified on Firefox 33 before the merge. > Since we haven't published a release yet, you'll have to adjust your > bower.json to install the fixed version manually: > > Replace "cloudinary_ng": "~1.0.0" with "cloudinary_ng": "#c7301f0" in > your bower.json and run bower install to get the latest code. > > Let me know if it works for you. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#65 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ACntcOHQ_-_ndFxByYlCmR9DOnF2h1dnks5rTJyXgaJpZM4LdKJ5> > . >
Need to add typeof check before attempting to evaluate NamedNodeMap
var isNamedNodeMap = source && (source.constructor.name === "NamedNodeMap" || source instanceof NamedNodeMap)
to
var isNamedNodeMap = source && (source.constructor.name === "NamedNodeMap" || (typeof NamedNodeMap != 'undefined' && source instanceof NamedNodeMap));