feat(testing): add unit tests for register#2719
Merged
Merged
Conversation
jsjoeio
marked this pull request as ready for review
February 12, 2021 00:04
jsjoeio
marked this pull request as draft
February 12, 2021 16:43
jsjoeio
force-pushed
the
add-tests-register
branch
from
February 12, 2021 17:09
fd91ae2 to
6996c45
Compare
jsjoeio
marked this pull request as ready for review
February 12, 2021 17:10
oxy
approved these changes
Feb 12, 2021
oxy
left a comment
There was a problem hiding this comment.
Looks good! Your choice on if you want a second opinion from asher on this one; I'm not too confident in my TS just yet 😅
Contributor
Author
|
I'll play it safe since we're releasing today - @code-asher would love an 👀 on this one! |
jsjoeio
commented
Feb 18, 2021
jsjoeio
force-pushed
the
add-tests-register
branch
from
February 18, 2021 18:32
6996c45 to
ecadf6c
Compare
jsjoeio
marked this pull request as draft
February 18, 2021 22:17
jsjoeio
force-pushed
the
add-tests-emitter
branch
from
February 18, 2021 23:56
1896154 to
5e287ad
Compare
jsjoeio
marked this pull request as ready for review
February 18, 2021 23:57
code-asher
requested changes
Feb 22, 2021
jsjoeio
marked this pull request as draft
February 22, 2021 17:38
jsjoeio
force-pushed
the
add-tests-emitter
branch
from
February 22, 2021 20:44
5e287ad to
325a1d8
Compare
jsjoeio
force-pushed
the
add-tests-register
branch
from
February 22, 2021 20:47
3233608 to
3eceb07
Compare
jsjoeio
force-pushed
the
add-tests-register
branch
2 times, most recently
from
February 23, 2021 23:03
14ad29a to
909d425
Compare
jsjoeio
marked this pull request as ready for review
February 23, 2021 23:27
jsjoeio
force-pushed
the
add-tests-register
branch
from
February 23, 2021 23:28
9e59e78 to
294b3d3
Compare
jsjoeio
commented
Feb 23, 2021
jsjoeio
force-pushed
the
add-tests-register
branch
from
February 26, 2021 19:04
54ea107 to
41d0794
Compare
code-asher
requested changes
Feb 26, 2021
jsjoeio
force-pushed
the
add-tests-register
branch
from
February 26, 2021 23:00
41d0794 to
66bb010
Compare
jsjoeio
force-pushed
the
add-tests-register
branch
from
February 26, 2021 23:05
66bb010 to
8c14799
Compare
Contributor
Author
|
CI only failed due to #2480 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few tests for
src/browser/register.ts.Screenshot
It increases our code coverage (Lines) from 50.09% to 51.13% (↑ 1.04%).
🟩 100% Line coverage (last 100) for
src/browser/register.tsTODOs
master