Skip to content

Remove default home#2800

Merged
code-asher merged 2 commits into
masterfrom
no-default-home
Mar 2, 2021
Merged

Remove default home#2800
code-asher merged 2 commits into
masterfrom
no-default-home

Conversation

@code-asher

Copy link
Copy Markdown
Member

No description provided.

This is preventing my ripgrep from searching vscode.
@code-asher code-asher changed the title Removeo default home Remove default home Mar 1, 2021
@code-asher
code-asher requested a review from a team March 1, 2021 19:21
@code-asher
code-asher changed the base branch from v3.9.0 to master March 1, 2021 19:22
@jsjoeio jsjoeio added this to the v3.9.1 milestone Mar 1, 2021

@jsjoeio jsjoeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are my favorite kind of PRs: short and sweet

  • tested by setting home in config. still works!
  • tested if home icon is removed when home isn't set

image

@greyscaled greyscaled linked an issue Mar 2, 2021 that may be closed by this pull request
@code-asher
code-asher merged commit 29f3021 into master Mar 2, 2021
@code-asher
code-asher deleted the no-default-home branch March 2, 2021 16:13
@reggiezhang

Copy link
Copy Markdown

"--home" no longer works on v3.9.2

@jsjoeio

jsjoeio commented Mar 29, 2021

Copy link
Copy Markdown
Contributor

@reggiezhang apologies! That should have been mentioned in the release notes (updating now) Added to release notes for 3.9.2.

VS Code removed that option so we had to remove it from code-server here: #2862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove default home value

3 participants