Skip to content

docs(README): add release shield#2813

Merged
jsjoeio merged 1 commit into
masterfrom
add-version-shield
Mar 2, 2021
Merged

docs(README): add release shield#2813
jsjoeio merged 1 commit into
masterfrom
add-version-shield

Conversation

@jsjoeio

@jsjoeio jsjoeio commented Mar 2, 2021

Copy link
Copy Markdown
Contributor

This PR adds a release shield to the README

Screenshot

image

@jsjoeio jsjoeio added this to the v3.9.1 milestone Mar 2, 2021
@jsjoeio
jsjoeio requested review from a team and greyscaled March 2, 2021 22:03
@jsjoeio jsjoeio self-assigned this Mar 2, 2021

@greyscaled greyscaled left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! One potential issue I could see is if a patch to prior release is newer by date than the latest release. We could get around that through using GitHub release (latest SemVer) from https://shields.io/category/version, but I don't suspect we'll face this problem atm.

Thanks for adding this! 🎉

@jsjoeio
jsjoeio force-pushed the add-version-shield branch from 063c67d to 16747f1 Compare March 2, 2021 22:14
@jsjoeio

jsjoeio commented Mar 2, 2021

Copy link
Copy Markdown
Contributor Author

Good call! I didn't think of that. I switched it to use the GitHub release (latest SemVer) as you suggested! 🙌

@jsjoeio
jsjoeio removed the request for review from a team March 2, 2021 22:20
@jsjoeio
jsjoeio merged commit 3ab0ff3 into master Mar 2, 2021
@jsjoeio
jsjoeio deleted the add-version-shield branch March 2, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants