feat(node-type-registry): sync the registry from constructive-db - #1755
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine sync of
packages/node-type-registry/srcfrom constructive-db (where the registry is authored against the platform that consumes it, and published from here). The published copy had drifted enough that blueprint table entries could not be typed at all against the module system.The notable gap this closes is the module selector plus selector-addressed
provisions, so a blueprint entry can attach security to a table an installed module generated — and own that table's security instead of only layering on top of it:Selector-level
policies/grantsstay additive; a non-emptypolicies/grantsarray inside aprovisionsentry declares that table's whole set.Also carried over with the sync: new node types (
AuthzHumanOnly,AuthzDatabaseClaim,DataLock), the new infra module types (image_module,repository_module,machine_module,infra_module,cluster_module,k8s_admission_module,internal_config_module), removal ofhttp_route_module, and preset/scope updates.__tests__/module-types.test.tshard-codes the module registry here (constructive-db derives the same list fromprovision_database_modules.sql), so its two expected lists were refreshed to match the synced registry.Verified:
pnpm build,pnpm test,pnpm lintin the package, andpnpm generate:typesreproduces the checked-inblueprint-types.generated.tsbyte-for-byte (identical to constructive-db's).Link to Devin session: https://app.devin.ai/sessions/123499ae0e9c48eba40a76dad95a2044
Requested by: @pyramation