Skip to content

Exit if run was not queued - #2

Closed
galargh wants to merge 1 commit into
coryschwartz:masterfrom
galargh:patch-1
Closed

Exit if run was not queued#2
galargh wants to merge 1 commit into
coryschwartz:masterfrom
galargh:patch-1

Conversation

@galargh

@galargh galargh commented Feb 17, 2022

Copy link
Copy Markdown

I've noticed a situation where the action would hang forever (6hrs) if it failed to queue a run.

That's why I think we should exit early if queuing a run failed. I decided to check if TGID was empty after scheduling to determine if it worked.

The alternative approach would be to set -e on the entire entrypoint.sh script. Personally, I'd prefer that but I do not know testground CLI well enough to judge if there are any situation in which we'd like to tolerate non-zero exit codes - which would prevent me from introducing this patch fix quickly.

Let me know what you think :)

Testing

Failure case: https://github.com/galargh/go-ipfs/runs/5231923598?check_suite_focus=true
Success case: https://github.com/galargh/go-ipfs/runs/5232065515?check_suite_focus=true

@lidel

lidel commented Feb 18, 2022

Copy link
Copy Markdown

cc @coryschwartz thoughts?

@galargh

galargh commented Mar 10, 2022

Copy link
Copy Markdown
Author

@coryschwartz have you had a chance to look at it?

@galargh

galargh commented Apr 14, 2022

Copy link
Copy Markdown
Author

I created the repo fork in testground org and merged this change in there - https://github.com/testground/testground-github-action.

@galargh galargh closed this Apr 14, 2022
@galargh
galargh deleted the patch-1 branch April 14, 2022 11:16
@coryschwartz

Copy link
Copy Markdown
Owner

Sorry about the delay!

But you know, it's probably better that this live in the testground repo anyway -- thanks for doing that.

I'll point to that repo in the README.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants