Repository navigation
Conversation
dayfine
force-pushed
the
bbq/reroll-log-line
branch
from
October 23, 2026 04:25
b3337bf to
2c4c9e5
Compare
dayfine
force-pushed
the
bbq/verified-reroll
branch
3 times, most recently
from
October 28, 2026 03:43
6ebb53d to
99d6497
Compare
A reroll's decision was logged when the panel was planned ("Reroll
selected. Rerolling quest."), with no slot or quest, and the reroll
itself logged nothing until it was verified. With two rerolls planned,
the second spent 10 BP ~30 s later with no line of its own (R5 12:45:40,
13:01:31), so log scans counted it as a reroll that was never selected.
reroll_quest(), which every slot reroll goes through, now logs
"Rerolling quest N (slug)." before it opens the panel, whatever the
result. The slug comes from BBQuests_enum_to_string(), as in the quest
reads, or is "unknown" for an undetected quest.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/verified-reroll
branch
from
October 28, 2026 08:14
99d6497 to
e6afd5e
Compare
dayfine
force-pushed
the
bbq/reroll-log-line
branch
from
October 28, 2026 08:14
2c4c9e5 to
d887e93
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
added a commit
that referenced
this pull request
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base:
bbq/verified-reroll(#8). Superseded by fork #2, now based on the same verified-reroll branch.The complete #27 head
6e9871d582495f3f6cc7ab8beed83d564da10bc0is an ancestor of #2 head57002fb3aeb785f7cd5c4146f23f30dfe8247bd9.BBQLoggerowns the slot/quest formatter, and the nine existing reroll outcome cases retain their exactly-once log assertions. #3 has also merged the consolidated #2.Native build/tests pass on Linux and Windows Clang at the consolidated #2 head; code health passes. The #3 Linux run explicitly passes all nine reroll, six logger and two screenshot cases. Remaining platform checks continue on #2/#3. This standalone PR is closed as redundant; its branch is retained for review history.