Skip to content

Superseded by #2: BBQ reroll diagnostics - #27

Closed
dayfine wants to merge 6 commits into
bbq/verified-rerollfrom
bbq/reroll-log-line
Closed

dayfine wants to merge 6 commits into
bbq/verified-rerollfrom
bbq/reroll-log-line

Conversation

@dayfine

@dayfine dayfine commented Oct 23, 2026 •

Copy link
Copy Markdown
Owner

Base: bbq/verified-reroll (#8). Superseded by fork #2, now based on the same verified-reroll branch.

The complete #27 head 6e9871d582495f3f6cc7ab8beed83d564da10bc0 is an ancestor of #2 head 57002fb3aeb785f7cd5c4146f23f30dfe8247bd9. BBQLogger owns the slot/quest formatter, and the nine existing reroll outcome cases retain their exactly-once log assertions. #3 has also merged the consolidated #2.

Native build/tests pass on Linux and Windows Clang at the consolidated #2 head; code health passes. The #3 Linux run explicitly passes all nine reroll, six logger and two screenshot cases. Remaining platform checks continue on #2/#3. This standalone PR is closed as redundant; its branch is retained for review history.

@dayfine
dayfine force-pushed the bbq/reroll-log-line branch from b3337bf to 2c4c9e5 Compare October 23, 2026 04:25
@dayfine
dayfine force-pushed the bbq/verified-reroll branch 3 times, most recently from 6ebb53d to 99d6497 Compare October 28, 2026 03:43
A reroll's decision was logged when the panel was planned ("Reroll
selected. Rerolling quest."), with no slot or quest, and the reroll
itself logged nothing until it was verified. With two rerolls planned,
the second spent 10 BP ~30 s later with no line of its own (R5 12:45:40,
13:01:31), so log scans counted it as a reroll that was never selected.

reroll_quest(), which every slot reroll goes through, now logs
"Rerolling quest N (slug)." before it opens the panel, whatever the
result. The slug comes from BBQuests_enum_to_string(), as in the quest
reads, or is "unknown" for an undetected quest.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
@dayfine
dayfine force-pushed the bbq/verified-reroll branch from 99d6497 to e6afd5e Compare October 28, 2026 08:14
@dayfine
dayfine force-pushed the bbq/reroll-log-line branch from 2c4c9e5 to d887e93 Compare October 28, 2026 08:14
@dayfine dayfine added farmer Farming programs game:sv Scarlet/Violet labels Nov 1, 2026
@dayfine dayfine changed the title BBQ Farmer: log one line naming the slot and quest for every reroll Superseded by #2: BBQ reroll diagnostics Nov 6, 2026
@dayfine dayfine closed this Nov 6, 2026
dayfine added a commit that referenced this pull request Nov 7, 2026
* Record published BBQ logging consolidation and retired PR27

* Record successful macOS Intel native validation of consolidated diagnostics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

farmer Farming programs game:sv Scarlet/Violet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant