Repository navigation
Conversation
dayfine
force-pushed
the
bbq/bp-reader-crop
branch
2 times, most recently
from
October 27, 2026 01:27
c2fde24 to
39ba660
Compare
dayfine
force-pushed
the
bbq/quest-detector-tests
branch
from
October 27, 2026 06:12
70e88c8 to
a58eceb
Compare
Owner
Author
|
Rebased onto the current |
dayfine
added a commit
that referenced
this pull request
Oct 27, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/bp-reader-crop
branch
from
October 28, 2026 06:00
39ba660 to
2aedcd0
Compare
dayfine
force-pushed
the
bbq/quest-detector-tests
branch
2 times, most recently
from
October 28, 2026 18:00
a252e4f to
543053f
Compare
dayfine
marked this pull request as draft
October 28, 2026 18:00
dayfine
force-pushed
the
bbq/quest-detector-tests
branch
from
October 28, 2026 18:43
543053f to
5d0cb36
Compare
Owner
Author
|
Opened upstream as PokemonAutomation#1759. |
dayfine
force-pushed
the
bbq/tests-file
branch
from
October 28, 2026 20:33
2779423 to
bf82b48
Compare
dayfine
force-pushed
the
bbq/quest-detector-tests
branch
from
October 28, 2026 20:33
5d0cb36 to
d01ac30
Compare
The two Traditional Chinese quest panel frames added for the BP reader also show three quests each. Read every slot at 1080p and 720p, and check that the empty fourth slot reads as nothing. The tests sit in the BBQ farmer's tests file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E
dayfine
force-pushed
the
bbq/tests-file
branch
from
October 28, 2026 20:37
bf82b48 to
daa1de3
Compare
dayfine
force-pushed
the
bbq/quest-detector-tests
branch
from
October 28, 2026 20:37
d01ac30 to
44e2a87
Compare
Owner
Author
|
Superseded by #180 (tests now live in the detector's own file, independent of PokemonAutomation#1754). Closed with the user's OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on PokemonAutomation#1754
BlueberryQuestDetector, the OCR the BBQ Farmer uses to read its quests, had no tests. The two Traditional Chinese quest panel frames that PokemonAutomation#1628 added for the BP reader also show three quests each, so this adds 16PokemonSV::BlueberryQuestDetectorcases to the BBQ farmer's own tests file: every slot of both frames at 1080p and 720p, with the empty fourth slot expected to read as nothing. One frame shows捕捉1隻…where the dictionary has捕捉一隻…, so the tests also cover the fuzzy match accepting that. All 16 pass locally alongside the other BBQ tests; like Chinese OCR in the app, they need the PaddleOCR detection model ("PaddleOCRDetection" in Settings → Resources).Part of PokemonAutomation/ComputerControl#263.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AKYzhrMnPK61XHWEch4a6E