Skip to content

Remove "minimumPipVersion" code (everything is "new enough" now) #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yosifkit merged 1 commit into from
Jun 3, 2022
Merged

Remove "minimumPipVersion" code (everything is "new enough" now) #733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions versions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ set -Eeuo pipefail
shopt -s nullglob

# https://github.com/docker-library/python/issues/365
minimumPipVersion='21.2.4'
minimumSetuptoolsVersion='57.5.0'
# for historical reasons, these get pinned to either the version bundled with each Python version or these, whichever is higher
# for historical reasons, setuptools gets pinned to either the version bundled with each Python version or this, whichever is higher

cd "$(dirname "$(readlink -f "$BASH_SOURCE")")"

Expand Down Expand Up @@ -137,12 +136,7 @@ for version in "${versions[@]}"; do
exit 1
fi

pipVersion="$(
{
echo "$pipVersion"
echo "$minimumPipVersion"
} | sort -rV | head -1
)"
# TODO remove this once Python 3.7 and 3.8 are either "new enough setuptools" or EOL
setuptoolsVersion="$(
{
echo "$setuptoolsVersion"
Expand Down