Fix complex property projection for entity splitting mappings#38592
Draft
AndriySvyryd with Copilot wants to merge 3 commits into
Draft
Fix complex property projection for entity splitting mappings#38592AndriySvyryd with Copilot wants to merge 3 commits into
AndriySvyryd with Copilot wants to merge 3 commits into
Conversation
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…tion Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix InvalidOperationException when using complex property
Fix complex property projection for entity splitting mappings
Jul 9, 2026
There was a problem hiding this comment.
Pull request overview
Fixes a relational query translation failure when projecting complex properties on split entities (SplitToTable) by resolving the complex property’s table based on actual mapped columns rather than assuming a single complex-type table mapping.
Changes:
- Updated the entity-splitting projection path in
CreateSelectto determine the complex-property table via newFindTable/TryFindTablehelpers using mapped columns (with JSON container support and nested complex-property recursion). - Added a regression test covering a split entity with a non-JSON complex property to ensure materialization works end-to-end.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/EFCore.Relational.Specification.Tests/Query/AdHocComplexTypeQueryRelationalTestBase.cs | Adds regression test Complex_property_on_split_entity for split-entity materialization with a non-JSON complex property. |
| src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.CreateSelect.cs | Fixes table resolution for complex properties under entity splitting by choosing a table based on mapped columns instead of Single() query mapping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queries over split entities (
SplitToTable) with a non-JSONComplexPropertycould fail during relational projection withSequence contains more than one element.The failure came from assuming a single complex-type mapping table in the split-entity projection path.
Root cause in relational projection
CreateSelect(entity-splitting branch) selected the complex property table via:complexProperty.ComplexType.GetQueryMappings().Single().TableQuery pipeline change
FindTable/TryFindTablehelpers to resolve the table by:Regression coverage
Complex_property_on_split_entityinAdHocComplexTypeQueryRelationalTestBase.Hook+HookMetadatasplit table withHook.Numberas complex type, and asserts materialization of both root and complex members.