Repository navigation
Clarify NegotiateAuthentication completion semantics - #134199
Merged
Merged
Conversation
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
MihaZupan
September 18, 2026 14:47
View session
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
MihaZupan
approved these changes
Sep 18, 2026
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The ContinueNeeded status needs to be described as an in-progress exchange.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR updates NegotiateAuthentication XML documentation to clarify authentication completion and status semantics for IntelliSense.
Changes:
- Clarifies
IsAuthenticatedbehavior. - Directs callers to
GetOutgoingBlobstatus codes. - Removes the misleading
IsAuthenticatedreference fromTargetName.
The documentation should distinguish ContinueNeeded as an in-progress exchange rather than implying authentication failure.
File summaries
| File | Summary |
|---|---|
src/libraries/System.Net.Security/src/System/Net/Security/NegotiateAuthentication.cs |
Updates public property documentation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
MihaZupan
enabled auto-merge (squash)
September 18, 2026 15:08
This was referenced Sep 18, 2026
Open
rzikm
approved these changes
Sep 21, 2026
Member
|
/ba-g Unrelated stuck runtime-libraries enterprise-linux pipeline |
MihaZupan
approved these changes
Sep 30, 2026
Member
|
@dotnet/ncl Can I get another review on this one please? 2 engineers aren't enough 🙃 |
wfurt
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the documentation improvements from dotnet/dotnet-api-docs#12724 into
NegotiateAuthenticationXML comments so they appear in IntelliSense.IsAuthenticatedindicates exchange completion, not success.GetOutgoingBlobstatus code.IsAuthenticatedreference fromTargetName.