Repository navigation
I can't get the tests running #115
Description
I am new with Docker so maybe its a noob issue, I have no clue on how to run the tests. Here is what I tried, with corresponding outputs:
docker-compose exec backend-tests /tests-start.sh
‘bash\r’: No such file or directory
docker-compose exec backend-tests \tests-start.sh
OCI runtime exec failed: exec failed: container_linux.go:346: starting container process caused "exec: "\\tests-start.sh": executable file not found in $PATH": unknown
docker-compose exec backend-tests tests-start.sh
OCI runtime exec failed: exec failed: container_linux.go:346: starting container process caused "exec: "tests-start.sh": executable file not found in $PATH": unknown
docker-compose exec backend bash
root@0dca8fc07bda:/app# DOMAIN=backend sh ./scripts/test.sh
sh: 0: Can't open ./scripts/test.sh
root@0dca8fc07bda:/app# sh scripts/test.sh
sh: 0: Can't open scripts/test.sh
root@0dca8fc07bda:/app# ls
Pipfile alembic alembic.ini app prestart.sh scripts tests-start.sh worker-start.sh
root@0dca8fc07bda:/app# sh tests-start.sh
tests-start.sh: 2: set: Illegal option -
Activity
slushnys commentedon Feb 22, 2020
that line should be ran from your local computer of your root directory.
Question offtopic:
I'm questioning the way this is tested, each time you want to tests, you must spawn new docker-compose? Where's productivity in that?
robido commentedon Feb 23, 2020
Thanks @slushnys can you elaborate more what you mean by root directory? Do you mean within bash within the container.
slushnys commentedon Feb 23, 2020
You have to execute DOMAIN=backend sh ./scripts/test.sh in your main folder which will spawn another backend container where it will run a script to execute pytest. After that you can enter the backend-tests container and run pytest whenever you want to 👍🏻
robido commentedon Feb 25, 2020
The command
DOMAIN=backend sh ./scripts/test.shdoes not work for me, I assume there is some difference between Linux and Windows for those commands. That is the error I get:'DOMAIN' is not recognized as an internal or external command,
operable program or batch file.
I finally was able to run the tests. To help others with the same issue, here is what worked:
docker-compose up -d). Docker: must be in Linux container mode (not Windows)docker-compose exec backend-tests /tests-start.shI saw a few of the issues are related to that CR+LF problem, I think it would be good to mention in in the README.md.
Thanks Tiangolo for the great FastAPI framework and this fullstack example.
tiangolo commentedon Apr 18, 2020
Thanks for the discussion here everyone!
About the CR LF problem, indeed, it's an issue with Cookiecutter in Windows: cookiecutter/cookiecutter#1159
But it should be fixed now on this side with: #149 🎉
Now after generating a new project line endings are fixed for shell files 🚀
github-actions commentedon Apr 29, 2020
Assuming the original issue was solved, it will be automatically closed now. But feel free to add more comments or create new issues.
✅ Add test for signing up and setup for dev `mailcatcher` (#115)