Repository navigation
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Pull Request Test Coverage Report for Build 9224869081Details
💛 - Coveralls |
arocheleau
marked this pull request as ready for review
May 16, 2024 19:57
IT-VBFK
reviewed
May 16, 2024
dennisdoomen
approved these changes
May 19, 2024
dennisdoomen
left a comment
Member
There was a problem hiding this comment.
Thanks. In addition to the comments from @IT-VBFK, I have nothing more to add than a suggestion
arocheleau
force-pushed
the
bug/2595/nullable-field-comparer
branch
from
May 21, 2024 20:15
e3aa155 to
21ecef5
Compare
arocheleau
force-pushed
the
bug/2595/nullable-field-comparer
branch
from
May 23, 2024 18:30
21ecef5 to
5dddcda
Compare
jnyrup
approved these changes
May 27, 2024
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Jul 14, 2024
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Jul 14, 2024
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Jul 14, 2024
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Aug 18, 2024
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Aug 18, 2024
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
jnyrup
pushed a commit
to jnyrup/fluentassertions
that referenced
this pull request
Aug 24, 2024
…e types (fluentassertions#2648) Handle custom comparer for nullable fields (fluentassertions#2595)
This was referenced Jul 21, 2025
This was referenced Aug 1, 2025
This was referenced Oct 12, 2026
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the
EqualityComparerEquivalencyStep<T>step is comparing the comparand's type against the equality comparer's type has been reviewed to take into account nullables.This fixes #2595.
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome