Fix JsonNodeAssertions.HaveProperty/NotHaveProperty for properties with explicit null values by Copilot · Pull Request #3282 · fluentassertions/fluentassertions

Copilot · 2026-07-28T09:03:35Z

JsonNodeAssertions<T>.HaveProperty/NotHaveProperty relied on Subject?[code] returning null to infer a missing property. Since JsonObject's indexer returns null both for an absent key and for a key explicitly set to JSON null, these assertions couldn't tell the two cases apart:

JsonNode json = JsonNode.Parse("""{ "id": 1, "name": null }""")!;

json.Should().NotHaveProperty("name"); // passed, even though "name" is present with a null value
json.Should().HaveProperty("name");    // failed, even though "name" exists

Changes

HaveProperty/NotHaveProperty now check presence via JsonObject.TryGetPropertyValue instead of the indexer, which distinguishes "key absent" from "key present with a null value"
Added spec coverage for a property with an explicit null value for both HaveProperty and NotHaveProperty
Documented the fix in docs/_pages/releases.md

Fixes JsonNodeAssertions.HaveProperty/NotHaveProperty cannot distinguish an absent property from one with an explicit null value #3281

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

github-actions · 2026-07-28T09:28:34Z

Test Results

37 files ± 0 37 suites ±0 2m 35s ⏱️ +5s
6 390 tests + 2 6 389 ✅ + 2 1 💤 ±0 0 ❌ ±0
39 686 runs +12 39 680 ✅ +12 6 💤 ±0 0 ❌ ±0

Results for commit e73901b. ± Comparison against base commit 8a7ddde.

This pull request removes 10 and adds 10 tests. Note that renamed tests count towards both.

FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
Object name: 'GetPositionExceptionMessage'.)

FluentAssertions.Specs.Specialized.JsonNodeSpecs+HaveProperty ‑ A_property_with_an_explicit_null_value_is_considered_present
FluentAssertions.Specs.Specialized.JsonNodeSpecs+HaveProperty ‑ A_property_with_an_explicit_null_value_is_not_considered_absent
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)

♻️ This comment has been updated with latest results.

…ing (#3283) Build/_build.csproj transitively pulled in System.Security.Cryptography.Xml 10.0.6, which has several known high-severity DoS vulnerabilities. Since Directory.Build.props sets TreatWarningsAsErrors, NuGet's audit warning (NU1903) is escalated to a build error, breaking restore for the Build project on every PR/branch (including #3282), unrelated to any code change. Pin a direct PackageReference to the patched 10.0.10 version to override the vulnerable transitive dependency. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-07-28T11:51:17Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI assigned Copilot and dennisdoomen Jul 28, 2026

Copilot AI review requested due to automatic review settings July 28, 2026 09:03

Copilot AI reviewed Jul 28, 2026

Copilot started work on behalf of dennisdoomen July 28, 2026 09:04

View session

Copilot AI linked an issue Jul 28, 2026 that may be closed by this pull request

JsonNodeAssertions.HaveProperty/NotHaveProperty cannot distinguish an absent property from one with an explicit null value #3281

Closed

Copilot AI review requested due to automatic review settings July 28, 2026 09:10

Copilot AI reviewed Jul 28, 2026

Copilot AI changed the title ~~[WIP] Fix JsonNodeAssertions to distinguish absent properties from null values~~ Fix JsonNodeAssertions.HaveProperty/NotHaveProperty for properties with explicit null values Jul 28, 2026

Copilot finished work on behalf of dennisdoomen July 28, 2026 09:10

Copilot AI requested a review from dennisdoomen July 28, 2026 09:10

dennisdoomen added the bug label Jul 28, 2026

dennisdoomen added this to the 8.11 milestone Jul 28, 2026

dennisdoomen marked this pull request as ready for review July 28, 2026 09:26

Copilot AI temporarily deployed to qodana-pr July 28, 2026 09:26 Inactive

dennisdoomen mentioned this pull request Jul 28, 2026

Pin System.Security.Cryptography.Xml to patched version to fix build restore failures #3283

Merged

jnyrup reviewed Jul 28, 2026

View reviewed changes

Comment thread Src/FluentAssertions/Specialized/JsonNodeAssertions.cs

Copilot started work on behalf of dennisdoomen July 28, 2026 12:11

View session

Copilot AI review requested due to automatic review settings July 28, 2026 12:14

Copilot AI reviewed Jul 28, 2026

Copilot finished work on behalf of dennisdoomen July 28, 2026 12:15

Copilot AI had a problem deploying to qodana-pr July 28, 2026 12:26 Failure

Copilot AI review requested due to automatic review settings July 28, 2026 12:36

dennisdoomen force-pushed the copilot/fix-jsonnodeassertions-null-check branch from 50867f0 to abbfdcb Compare July 28, 2026 12:36

dennisdoomen temporarily deployed to qodana-pr July 28, 2026 12:36 — with GitHub Actions Inactive

Copilot started reviewing on behalf of dennisdoomen July 28, 2026 12:36

View session

dennisdoomen requested a review from jnyrup July 28, 2026 12:37

Navigation Menu

Repository navigation

Fix JsonNodeAssertions.HaveProperty/NotHaveProperty for properties with explicit null values - #3282

Fix JsonNodeAssertions.HaveProperty/NotHaveProperty for properties with explicit null values#3282
dennisdoomen merged 2 commits into
mainfrom
copilot/fix-jsonnodeassertions-null-check

Copilot AI commented Jul 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Copilot AI commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qodana for .NET

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading

github-actions Bot commented Jul 28, 2026 •

edited

Loading