Repository navigation
[webview_flutter_lwe] Bind the integration test server to the loopback address - #1215
Merged
seungsoo47 merged 1 commit intoNov 10, 2026
Merged
Conversation
…k address The test server was bound to InternetAddress.anyIPv4 and its address (0.0.0.0) was reused as the request URL. On emulators launched with a host proxy, 0.0.0.0 is not covered by no_proxy, so requests went to the proxy and getCookies failed. Bind to InternetAddress.loopbackIPv4 like upstream.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JSUYA
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test server was bound to
InternetAddress.anyIPv4, and its address (0.0.0.0) was reused as the request URL. This PR binds the server toInternetAddress.loopbackIPv4instead, as the upstreamwebview_fluttertest does, so the URL becomeshttp://127.0.0.1:<port>.On emulators launched with a host proxy (e.g. via
em-cli/Emulator Manager withproxyMode=auto), the app inheritshttp_proxyandno_proxy=localhost,127.0.0.1/8,10.0.2.0/24.0.0.0.0is not covered byno_proxy, so requests to the test server went through the proxy, which returnedNetwork Error (tcp_error).onPageFinishedstill fired, butSet-Cookie: foo=barwas never received, sogetCookiesreturned an empty list. This was found while enablingwebview_flutter_lwein the CI recipe (#1188).Results of the
webview_flutter_lweintegration test:anyIPv4(before)loopbackIPv4(after)getCookiesfails (13/14)getCookiesfails (13/14)The failure is not related to the engine version: it reproduced with LWE 1.4.1, 1.5.1 and 1.5.11 on the TV 9.0 emulator.
🤖 Generated with Claude Code