Repository navigation
ci: Drop --verbose from the external-link PR check - #19678
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
`lychee.toml` sets `base_url = "https://docs.sentry.io"` and then excludes that host, since internal links are lint-404s' job. With `--verbose`, lychee prints every one of those excluded links, so the PR check becomes a wall of `[EXCLUDED]` lines with the real failures buried inside. On #19639 that was 1563 excluded lines around 12 errors. Measured on 60 files from that PR: with --verbose: 404 lines of output without --verbose: 9 lines, and the single real 404 is the only thing in the body Failures are also reported in more detail without it. On a warm cache `--verbose` collapses them to `| Error (cached)`, while the default output gives the status and reason: [404] https://github.com/... | Rejected status code: 404 Not Found Redirect details are verbose-only, but they are not worth the noise here: the PR job reads mostly from a shared cache and cached entries do not re-report redirects, which is why #19639's summary showed 0 redirects despite the corpus containing plenty. The weekly full scan keeps --verbose and is where that auditing belongs. The redirect count and the "re-run with -v" hint still appear on PRs, so nothing is silently lost. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
coolguyzone
force-pushed
the
coolguyzone/chore/quiet-lychee-pr-check
branch
from
September 29, 2026 18:32
5ad98b3 to
4f02270
Compare
sergical
approved these changes
Sep 29, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
The
check-prexternal-link check is currently unreadable.lychee.tomlsetsbase_url = "https://docs.sentry.io"and then excludes that host (internal links arelint-404s' job) — and--verboseprints every excluded link. So the check becomes a wall of[EXCLUDED]lines with the real failures buried somewhere inside.On #19639 that was 1,563 excluded lines around 12 actual errors.
This drops
--verbosefrom the PR job only. The weekly full scan keeps it.Measured on 60 files from that PR
And the entire body of the quiet run is the thing you actually want:
Failures get more detail, not less
On a warm cache
--verbosecollapses errors to a bare| Error (cached). The default output gives the status and the reason:What you lose, and why it doesn't matter here
Redirect details are verbose-only:
That's genuinely useful — but not on this job. The PR run reads mostly from a shared cache, and cached entries don't re-report redirects, which is exactly why #19639's summary showed
🔀 Redirected | 0even though the corpus has plenty. The weekly scheduled scan (args: --verbose .) populates that cache and is where redirect auditing belongs, so it keeps--verboseuntouched.The redirect count and lychee's own "re-run in verbose mode to see details" hint still appear on PRs, so nothing is silently dropped.
Verification
Tested locally with the pinned lychee
0.23.0(the same versionscripts/lint-external-links.mjsinstalls), against real files from #19639, with both a cold and a warm cache.One thing I could not test locally: the job also sets
jobSummary: true, and I can't exercise the action's summary generation outside CI. Non-verbose still prints per-file errors, so the summary should be unchanged — worth a glance on the first run of this PR to confirm.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code