Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
The plan checks page loads of the changed setup page, client errors on that page, and platform 404s. An issue escalates when client errors appear on that page or 404s rise. Services: Mention PlanWhat changedThe .NET Crons setup page now leads with WithMonitor wrap examples. Manual CaptureCheckIn calls move to a Manual Check-Ins subsection. sentry-docs must deploy before this copy is live. The page path is RiskReaders may copy WithMonitor on an SDK older than the documented version. A broken include can raise client errors on that page. The blast radius is that one setup page. Other platform Crons pages do not ship this include. Intended effectThis change rewrites page copy. Telemetry cannot show that WithMonitor now leads the page. Regression watchA bad include can 404 the page or throw in the new code blocks. Hold the bands below. A drop of page loads to zero with a rise in 404s is a regression. New client errors on this path are a regression.
The 404 metric stores only the first two path segments. It covers all .NET platform 404s, not this page alone. Pair it with page loads on Not observableThe new heading and WithMonitor samples are not in telemetry. Pageload spans for this path returned zero. Navigation spans were 3 in 7 days, so p95 latency is not a usable band. |
| }, options => options.Interval("0 * * * *")); | ||
| ``` | ||
|
|
||
| Exceptions thrown by the job are rethrown, and the job's return value is passed through. `SentrySdk.WithMonitor` requires a Sentry .NET SDK version newer than `6.12.0`. If the monitor already exists in Sentry, you can leave out the monitor options. |
There was a problem hiding this comment.
Bug: The documentation for SentrySdk.WithMonitor uses a placeholder SDK version, newer than 6.12.0, which needs to be updated before merging.
Severity: MEDIUM
Suggested Fix
Before merging the pull request, replace the placeholder version string "newer than 6.12.0" with the actual minimum required SDK version that includes the SentrySdk.WithMonitor feature, as indicated in the PR description.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: platform-includes/crons/setup/dotnet.mdx#L23
Potential issue: The documentation file `platform-includes/crons/setup/dotnet.mdx`
specifies that using `SentrySdk.WithMonitor` requires a Sentry .NET SDK version "newer
than `6.12.0`". However, the pull request description explicitly states this is a
placeholder value. Merging the pull request in its current state will result in
publishing incorrect information about the minimum required SDK version, which could
lead to user confusion and setup issues.
Did we get this right? 👍 / 👎 to inform future reviews.
|
Hi @wedamija, thanks for all the work on this topic! :) We should probably also edit the getting started page to mention .NET when this goes in, right? |
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
DESCRIBE YOUR PR
The .NET crons setup page now leads with
SentrySdk.WithMonitor(async and sync examples). ManualCaptureCheckIncalls move to a "Manual Check-Ins" subsection below it.SDK PR: getsentry/sentry-dotnet#5664
Merge after the SDK release that includes it, and replace "newer than
6.12.0" with that version.IS YOUR CHANGE URGENT?