You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jul 1, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 1, 2020. It is now read-only.
I was on 1.5.18 when I noticed it, I narrowed it down to the 1.5.13 change (I think)
I think it's this in validation-directive.js
scope.$on('angularValidation.revalidate',function(event,args){if(args==ctrl.$name){ctrl.revalidateCalled=true;varvalue=ctrl.$modelValue;if(!!elm&&elm.hasOwnProperty("isValidationCancelled")){// attempt to validate & run validation callback if user requested itvarvalidationPromise=attemptToValidate(value);if(!!_validationCallback){commonObj.runValidationCallbackOnPromise(validationPromise,_validationCallback);}}else{ctrl.$setValidity('validation',true);}}});
elm.hasOwnProperty("isValidationCancelled") doesn't seem to ever evaluate to true.
I'm not 100% sure, but I think elm is wrong type of thing to be evaluating, that other parts of the code are setting that property on a different object.
What I suggest you to do is to debug it using the plunker sample you got and use validation-directive.js of version 1.5.18 and then revert some of the code change of the old version vs new version until you find the culprit. If you can find what it is, I can help out afterward.
Activity
ghiscoding commentedon Apr 14, 2017
Latest version is
1.5.18, you're quite behind. Can you troubleshoot and find the problem, because I don't have much time to look into this right now.Try with latest version just to see
jsolt commentedon Apr 14, 2017
I was on 1.5.18 when I noticed it, I narrowed it down to the 1.5.13 change (I think)
I think it's this in validation-directive.js
elm.hasOwnProperty("isValidationCancelled") doesn't seem to ever evaluate to true.
I'm not 100% sure, but I think elm is wrong type of thing to be evaluating, that other parts of the code are setting that property on a different object.
ghiscoding commentedon Apr 14, 2017
What I suggest you to do is to debug it using the plunker sample you got and use
validation-directive.jsof version1.5.18and then revert some of the code change of the old version vs new version until you find the culprit. If you can find what it is, I can help out afterward.Thanks for the help
Fix #150 angularValidation.revalidate problems
ghiscoding commentedon Apr 18, 2017
New release v1.5.19 pushed with your fix. Thanks again for the contribution :)
jsolt commentedon Apr 18, 2017
Awesome, thanks for the super quick turnaround, now we're up to the latest version again :)