Skip to content

lazyDefine components#268

Merged
keithamus merged 21 commits into
mainfrom
lazy-define
Aug 4, 2022
Merged

lazyDefine components#268
keithamus merged 21 commits into
mainfrom
lazy-define

Conversation

@koddsson

@koddsson koddsson commented Aug 1, 2022

Copy link
Copy Markdown
Contributor

Upstream a lazyDefine function from github/github and add some tests.

@koddsson koddsson requested a review from a team as a code owner August 1, 2022 16:34
@koddsson koddsson requested a review from srt32 August 1, 2022 16:34
Comment thread src/lazy-define.ts Outdated
Comment thread src/lazy-define.ts
Comment thread src/lazy-define.ts Outdated
Comment thread test/lazy-define.ts Outdated
Comment thread test/lazy-define.ts Outdated
@keithamus

Copy link
Copy Markdown
Contributor

This looks good, we should add some documentation and export it from index 😆

koddsson and others added 21 commits August 4, 2022 11:55
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
This prevents callbacks being called twice or more for a given dynamic
element.

Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
@keithamus keithamus merged commit e81d778 into main Aug 4, 2022
@keithamus keithamus deleted the lazy-define branch August 4, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants