Sync dbschemes - #12849
Conversation
|
What's the upgrade-script requirement on Go changes like |
| case @diagnostic.severity of | ||
| 10 = @diagnostic_debug | ||
| | 20 = @diagnostic_info | ||
| | 30 = @diagnostic_warning | ||
| | 40 = @diagnostic_error | ||
| ; |
There was a problem hiding this comment.
This simply does not hold for the trap produced by the c extractor, which produces severities in the range [0, ..., 5].
There was a problem hiding this comment.
Good point. This snippet comes from Ruby where we use this numbering scheme. In the end it does not matter too much which numbers are used. We could just as well adjust the Ruby extractor. If we can use the same numbers across languages that would be nice.
RasmusWL
left a comment
There was a problem hiding this comment.
Looks really good! I'm leaving a 'request changes' review since the Python file is generated by an internal tool, so we need to do some adjustments to that to ensure we don't just go back to the old versions next time we run that tool 😅
No description provided.