Skip to content

Swift: Models and tests for numeric conversions - #13946

Merged
geoffw0 merged 21 commits into
github:mainfrom
geoffw0:arraysteptest
Sep 22, 2023
Merged

Swift: Models and tests for numeric conversions#13946
geoffw0 merged 21 commits into
github:mainfrom
geoffw0:arraysteptest

Conversation

@geoffw0

@geoffw0 geoffw0 commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

Add models and tests for (mostly) numeric conversions.

Fixed a flow issue with OptionalSomePattern I bumped into on the way.

TODO:

  • can we catch this one as well:
	sink(arg: [UInt8](sourceString().utf8)) // $ MISSING: tainted=
  • DCA run

@geoffw0

geoffw0 commented Aug 31, 2023

Copy link
Copy Markdown
Contributor Author

DCA LGTM. I will fix the merge conflicts after this has had an initial review.

@d10c d10c left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffw0

geoffw0 commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

Fixed merge conflicts. Changes after the merge need a quick review.

There were a number of changes to various test results as a result of the merge. One was a good change, the other two were undesirable. I've addressed them by adding proper barriers for Numeric values (in particular Int) in five injection-like queries. Previously we were depending on data flow not actually working through the constructs that were involved.

@geoffw0

geoffw0 commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

... I should probably add a second change note for the barriers ...

@geoffw0

geoffw0 commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

Second change note added (with no mention of the command injection query as it's still in experimental).

And added the numeric barrier to the regular expression injection query as well.

@d10c d10c left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@geoffw0
geoffw0 merged commit 2c9433c into github:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants