Skip to content

Dataflow perf investigations - #15444

Draft
hvitved wants to merge 19 commits into
github:mainfrom
hvitved:dataflow-perf-investigations
Draft

Dataflow perf investigations#15444
hvitved wants to merge 19 commits into
github:mainfrom
hvitved:dataflow-perf-investigations

Conversation

@hvitved

@hvitved hvitved commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security AI found potential problems Jan 26, 2024
View reviewed changes
Comment thread java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
}

pragma[nomagic]
private predicate isExactArgument(ArgumentNode arg, BasicBlock bb, Method m, ArgumentPosition apos) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
}

pragma[nomagic]
private predicate setsInstanceField(Field f, Node qualifier, BasicBlock bb) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
}

pragma[nomagic]
private predicate isInstanceFieldSetter(Method m, ArgumentPosition apos, Field f) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
)
}

private predicate sdf(Field f, Class c) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
)
}

/** A debug predicate for identifying the most busy node in forwards flow. */

Check warning

Code scanning / CodeQL

Predicate QLDoc style.

The QLDoc for a predicate without a result should start with 'Holds'.
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
)
}

/** A debug predicate for identifying the most busy node in reverse flow. */

Check warning

Code scanning / CodeQL

Predicate QLDoc style.

The QLDoc for a predicate without a result should start with 'Holds'.
@hvitved
hvitved force-pushed the dataflow-perf-investigations branch from b4b45d6 to 069406e Compare January 30, 2024 10:55
github-advanced-security[bot]
github-advanced-security AI found potential problems Jan 30, 2024
View reviewed changes
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
pragma[nomagic]
private predicate fwdFlowConsCand(Typ t2, Ap cons, Content c, Typ t1, Ap tail) {
fwdFlowStore(_, t1, tail, c, t2, _, _, _, _, _, _) and
private predicate fwdFlowConsCandNoStrenght(

Check warning

Code scanning / CodeQL

Misspelling

This predicate name contains the common misspelling 'strenght', which should instead be 'strength'.
@hvitved
hvitved force-pushed the dataflow-perf-investigations branch from 73da939 to 147f854 Compare February 8, 2024 16:22
github-advanced-security[bot]
github-advanced-security AI found potential problems Feb 8, 2024
View reviewed changes
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll Fixed
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll Fixed
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
pragma[nomagic]
additional predicate nodeMayFlowThrough(ParamNode p, Ap argAp, NodeEx node, Ap ap) {
// revFlow(node, _, TReturnCtxMaybeFlowThrough(_), _, ap)
exists(ApOption argApO, ReturnPosition pos, Ap returnAp, ApOption returnApO |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable

This exists variable can be omitted by using a don't-care expression [in this argument](1).
Comment thread java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll
result.asSummarizedCallable().getACall() = c.asCall()
}

private DataFlowCallable viableCallable(DataFlowCall c, int k) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll
mayBenefitFromCallContext(call.asCall(), _, _)
}

private DataFlowCallable testviableImplInCallContext(DataFlowCall call, DataFlowCall ctx) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll
}

pragma[nomagic]
private predicate foo(DataFlowCall call, DataFlowCall ctx1, DataFlowCall ctx2) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll
)
}

private DataFlowCallable testviableImplInCallContext(

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread java/ql/lib/semmle/code/java/dataflow/internal/DataFlowPrivate.qll
erasedHaveIntersection(t1, t2)
}

private predicate sdef(DataFlowType t1, DataFlowType t2) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll Fixed
@hvitved
hvitved force-pushed the dataflow-perf-investigations branch from 147f854 to f8347e9 Compare February 21, 2024 12:39
github-advanced-security[bot]
github-advanced-security AI found potential problems Feb 21, 2024
View reviewed changes
Comment thread java/ql/lib/semmle/code/java/security/TaintedPathQuery.qll
sanitizer instanceof PathInjectionSanitizer
sanitizer instanceof PathInjectionSanitizer or
sanitizer.getLocation().getFile().getBaseName() =
[/*"BaseObject.java", "SimpleNode.java",*/ "Context.java"]

Check warning

Code scanning / CodeQL

Singleton set literal

Singleton set literal can be replaced by its member.
Comment thread java/ql/lib/semmle/code/java/dataflow/internal/DataFlowDispatch.qll
result.asSummarizedCallable().getACall() = c.asCall()
}

private DataFlowCallable testviableCallable(DataFlowCall c) {

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
private module Stage3 = MkStage<Stage2_5>::Stage<Stage3Param>;

// private predicate mostBusyNodeFwd3 = Stage3::mostBusyNodeFwd/10;
private predicate mostBusyNodeFwd3_5 = Stage3_5::mostBusyNodeFwd/10;

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
private predicate mostBusyNodeFwd3_5 = Stage3_5::mostBusyNodeFwd/10;

// private predicate mostBusyNodeFwd4 = Stage4::mostBusyNodeFwd/10;
private predicate mostBusyNodeFwd5 = Stage5::mostBusyNodeFwd/10;

Check warning

Code scanning / CodeQL

Dead code

This code is never used, and it's not publicly exported.
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
ArgTyp argT, Ap argAp, ApApprox argApa, Typ t, TypOption origT, Ap ap, ApApprox apa,
boolean allowsFieldFlow
) {
exists(DataFlowCall call, RetNodeEx ret |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable

This exists variable can be omitted by using a don't-care expression [in this argument](1).
Comment thread shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll
ApApprox argApa, Typ t, TypOption origT, Ap ap, ApApprox apa, boolean allowsFieldFlow
) {
exists(ReturnKindExt kind |
exists(DataFlowCall call, ReturnKindExt kind |

Check warning

Code scanning / CodeQL

Omittable 'exists' variable

This exists variable can be omitted by using a don't-care expression [in this argument](1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

C# C++ DataFlow Library Go Java Python Ruby Swift

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hvitved @github-advanced-security