C++: Add an interface for models to block flow - #15528
Merged
Merged
Conversation
rdmarsh2
approved these changes
Feb 6, 2024
rdmarsh2
left a comment
Contributor
There was a problem hiding this comment.
Code and tests LGTM. There's a fair bit of noise on the DCA run, it might be worth rechecking some of the projects with bigger slowdowns.
Contributor
Author
Thanks! I'm not sure what slowdowns you're referring to? The largest slowdown is Stage timing is also showing a less-than-5% slowdown which I think we can attribute to noise |
Merged
MathiasVP
added a commit
that referenced
this pull request
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new abstract class
FlowOutBarrierFunctionfor blocking flow out of a function model. One of the obvious examples isstd::swapwhere we onmainhas this FP:This PR adds an interface for specifying that such functions shouldn't have flow out of a given
FunctionInput. Operationally, this amounts to blocking use-use flow once the data reaches the function's input.In this PR I've just implemented the class on
std::swap. Once the change is in we can provide extents for a bunch of other classes that we currently model.