Swift: fix ARM build and add it to CI - #16025
Draft
redsun82 wants to merge 6 commits into
Draft
Conversation
redsun82
force-pushed
the
redsun82/swift-fix-arm-build
branch
2 times, most recently
from
March 22, 2024 16:05
08534e9 to
470b816
Compare
redsun82
force-pushed
the
redsun82/swift-fix-arm-build
branch
from
March 22, 2024 16:15
470b816 to
9bac975
Compare
redsun82
marked this pull request as ready for review
March 22, 2024 16:17
As pointed out in bazelbuild/bazel#21768, bazel 7 moved multi-arch macOS toolchain support to `apple_support`, so building Swift (which must target `x86_64` for now) was broken. Internally in the codeql CLI we were unaffected as we use a custom bundled toolchain. This fixes building from this repository.
Also: * removed the pretty much non-functioning bazel cache, will come back to it when we have a broader solution * replaced sharing the extractor pack via cache with uploading and downloading it
The problems running on arm are concerning, but may be caused by not building with the internal macOS toolchain. We'll do separate work internally to investigate and possibly fix that. In the meantime, we can keep testing on intel as is currently done in main.
They are now run internally by QLucie.
redsun82
force-pushed
the
redsun82/swift-fix-arm-build
branch
from
April 3, 2024 06:36
464143c to
d0644d0
Compare
redsun82
marked this pull request as draft
April 10, 2024 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in bazelbuild/bazel#21768, bazel 7 moved multi-arch macOS toolchain support to
apple_support, so building Swift (which must targetx86_64for now) was broken. Internally in the codeql CLI we were unaffected as we use a custom bundled toolchain.This fixes building from this repository.
Moreover, various CI fixes have been added: