Skip to content

SSA: Add BasicBlock.{getNode/1,length/0} to the input signature - #16896

Merged
hvitved merged 1 commit into
github:mainfrom
hvitved:ssa/dataflow-integration-prep
Jul 3, 2024
Merged

hvitved merged 1 commit into
github:mainfrom
hvitved:ssa/dataflow-integration-prep

Conversation

@hvitved

@hvitved hvitved commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

In preparation for #16884.

* by calling `begin` (or related functions) on the variable `v`.
*/
predicate variableWrite(IRBlock bb, int i, SourceVariable v, boolean certain) {
predicate variableWrite(BasicBlock bb, int i, SourceVariable v, boolean certain) {

Check warning

Code scanning / CodeQL

Missing QLDoc for parameter

The QLDoc has no documentation for certain, but the QLDoc mentions begin
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Jul 3, 2024
@hvitved
hvitved marked this pull request as ready for review July 3, 2024 12:33
@hvitved
hvitved requested review from a team as code owners July 3, 2024 12:33
@hvitved
hvitved requested a review from MathiasVP July 3, 2024 12:33

@MathiasVP MathiasVP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if DCA is happy!

@hvitved
hvitved merged commit da0909c into github:main Jul 3, 2024
@hvitved
hvitved deleted the ssa/dataflow-integration-prep branch July 3, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants