Skip to content

fix: missed where opporunity false positive #22484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelnebel merged 9 commits into from
Sep 3, 2026
Merged

fix: missed where opporunity false positive #22484

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
41ad940
fix: missed where opporunity false positive
baywet Sep 1, 2026
dc42a4c
docs: rewording
baywet Sep 1, 2026
17412f3
tests: adds a unit test to prevent regression on else cases
baywet Sep 1, 2026
3271587
chore: fixes missing break case
baywet Sep 1, 2026
5e11c9a
tests: adds a negative test for break
baywet Sep 1, 2026
dd005e5
chore: applies review suggestion
baywet Sep 2, 2026
d6ffc18
docs: removes additional cases to avoid the page being too long
baywet Sep 2, 2026
2a7faa5
chore: applies review suggestion
baywet Sep 3, 2026
dd84d7f
docs: adds change note for linq where fixes
baywet Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs: adds change note for linq where fixes
  • Loading branch information
@baywet
baywet committed Sep 3, 2026
commit dd84d7f14473cb1f025259f8c4c935b7e86b8697
4 changes: 4 additions & 0 deletions csharp/ql/src/change-notes/2026-09-03-missed-where-terminal-branches.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The `cs/linq/missed-where` query no longer flags `foreach` loops where the matching branch terminates the method, iterator, or loop instead of continuing with filtered loop work.
Loading