JS: Add src as an unsafe DOM property for js/xss-through-dom. - #6549
Merged
Conversation
erik-krogh
marked this pull request as ready for review
August 31, 2021 06:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And propagate field-flow from writes in a super-class to reads in a sub-class.
Gets a TP/TN for CVE-2021-23414.
Evaluation looks OK-ish in terms of performance.
There is a few new results.
The bootstrap result is an FP (failed to recognize sanitizer).
And another result is flow from one
srcattribute to anothersrcattribute, which is safe.I'll look at fixing those FPs in a followup PR.
I wasn't sure about the performance from the above evaluation, so I ran another one.
And performance looks fine there.