Skip to content

C++: Fix join order in bbSuccessorEntryReaches #8882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MathiasVP wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

C++: Fix join order in bbSuccessorEntryReaches #8882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cpp/ql/lib/semmle/code/cpp/controlflow/StackVariableReachability.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ abstract class StackVariableReachability extends string {
)
}

pragma[nomagic]
private predicate bbSuccessorEntryReaches(
BasicBlock bb, SemanticStackVariable v, ControlFlowNode node,
boolean skipsFirstLoopAlwaysTrueUponEntry
Expand All @@ -103,8 +104,9 @@ abstract class StackVariableReachability extends string {
this.bbEntryReachesLocally(succ, v, node) and
succSkipsFirstLoopAlwaysTrueUponEntry = false
or
not this.isBarrier(succ.getNode(_), v) and
this.bbSuccessorEntryReaches(succ, v, node, succSkipsFirstLoopAlwaysTrueUponEntry)
not this.isBarrier(succ.getNode(_), pragma[only_bind_into](v)) and
this.bbSuccessorEntryReaches(succ, pragma[only_bind_into](v), node,
succSkipsFirstLoopAlwaysTrueUponEntry)
)
}

Expand Down