fix: mock accessSync in workdir-setup test to avoid macOS false failure by lpcox · Pull Request #6050 · github/gh-aw-firewall

lpcox · 2026-07-09T03:45:01Z

Problem

The test ensureDirectory EACCES diagnostic › falls back to nearest existing ancestor when no ancestor fails the access check fails on macOS because it assumes all real ancestor directories pass the W_OK|X_OK access check.

On macOS, /var/folders/dl (a system-managed temp directory parent) fails this check, causing the blocker variable to be set to a system directory instead of falling through to the nearestExisting fallback as the test expects.

Fix

Mock fs.accessSync to always pass (return undefined) in this specific test, ensuring the "no ancestor fails" fallback path is reliably exercised regardless of host filesystem permissions.

This is consistent with the test's intent — it explicitly tests the fallback behavior when no ancestor fails the access check.

The test 'falls back to nearest existing ancestor when no ancestor fails the access check' assumed all real ancestor directories pass the W_OK|X_OK check. On macOS, /var/folders/dl fails this check, causing the test to fail because a system directory becomes the blocker instead of falling through to the nearestExisting fallback. Fix by mocking accessSync to always pass, ensuring the fallback path is reliably exercised regardless of host filesystem permissions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-07-09T03:47:20Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	98.99%	99.02%	📈 +0.03%
Statements	98.95%	98.99%	📈 +0.04%
Functions	99.45%	99.45%	➡️ +0.00%
Branches	95.71%	95.71%	➡️ +0.00%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/log-directory-setup.ts`	96.2% → 100.0% (+3.78%)	96.3% → 100.0% (+3.71%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-07-09T03:48:24Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

github-actions · 2026-07-09T03:48:25Z

🌑 The shadows whisper... Smoke Codex failed. The oracle requires further meditation...

github-actions · 2026-07-09T03:48:27Z

🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅

github-actions · 2026-07-09T03:48:27Z

🔌 Smoke Services — All services reachable! ✅

github-actions · 2026-07-09T03:48:27Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

github-actions · 2026-07-09T03:48:28Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-07-09T03:48:28Z

✅ Build Test Suite completed successfully!

github-actions · 2026-07-09T03:48:28Z

✅ Contribution Check completed successfully!

PR #6050 follows the applicable CONTRIBUTING.md guidelines based on the provided context; no review comment needed.

github-actions · 2026-07-09T03:48:29Z

❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed...

github-actions · 2026-07-09T03:48:29Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

github-actions · 2026-07-09T03:48:29Z

✅ Smoke Gemini completed. All facets verified. 💎

github-actions · 2026-07-09T03:48:29Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

github-actions · 2026-07-09T03:48:36Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

github-actions · 2026-07-09T03:48:42Z

✅ Smoke Claude passed

Copilot

Pull request overview

This PR makes the ensureDirectory EACCES diagnostic test suite deterministic across platforms by removing an assumption about real filesystem permissions on ancestor directories (notably on macOS under /var/folders/...).

Changes:

Updates the “falls back to nearest existing ancestor when no ancestor fails the access check” test to mock fs.accessSync as always succeeding.
Improves the inline test comment to document the macOS-specific failure mode being avoided.

Show a summary per file

File	Description
`src/workdir-setup.test.ts`	Mocks `fs.accessSync` in one test to reliably exercise the “no ancestor fails access check” fallback path on all OSes.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 1/1 changed files
Comments generated: 0
Review effort level: Low

github-actions · 2026-07-09T03:54:25Z

Smoke Test: Claude Engine Validation

Check	Result
API status	✅ PASS
GH check	✅ PASS
File status	✅ PASS

Overall result: PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Smoke Claude for #6050 · 55.2 AIC · ⊞ 3.3K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-09T03:54:28Z

Smoke Test: Copilot PAT Auth

Test	Status
GitHub MCP connectivity	✅
GitHub.com HTTP	✅ (200)
File write/read	✅

Overall: PASS | Auth mode: PAT (COPILOT_GITHUB_TOKEN)
@lpcox

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔑 PAT report filed by Smoke Copilot PAT
_{Add label ready-for-aw to run again}

github-actions · 2026-07-09T03:56:04Z

PR titles:
${{ steps.smoke-data.outputs.SMOKE_PR_DATA }}

MCP PR list validation: ✅
GitHub.com connectivity: ✅
File I/O test: ✅
Direct BYOK inference: ✅

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)

PASS

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)
_{Add label ready-for-aw to run again}

github-actions · 2026-07-09T03:56:05Z

Smoke Test: Services Connectivity

Redis PING: ❌ (Network is unreachable)
PostgreSQL pg_isready: ❌ (no response)
PostgreSQL SELECT 1: ❌ (Network is unreachable)

Overall: FAIL — host.docker.internal (172.17.0.1) unreachable from sandbox.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-07-09T03:56:32Z

Chroot Version Comparison Results

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.13	Python 3.12.3	❌ NO
Node.js	v24.18.0	v22.23.1	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Overall: ALL_TESTS_PASSED=false — Python and Node.js versions differ between host and chroot environments.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-09T03:56:37Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 passed	✅ PASS
Go	env	✅	1/1 passed	✅ PASS
Go	uuid	✅	1/1 passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	All passed	✅ PASS
Node.js	execa	✅	All passed	✅ PASS
Node.js	p-limit	✅	All passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — ✅ PASS

Note: Java tests initially failed due to root-owned ~/.m2 directory (no sudo available). Resolved by using -Dmaven.repo.local=/tmp/gh-aw/agent/.m2/repository flag.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Build Test Suite for #6050 · 35.7 AIC · ⊞ 6.9K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-07-09T03:56:50Z

🔬 Smoke Test Results

Test	Result
GitHub MCP	✅ Connected
GitHub.com HTTP	✅ 200 OK
File Write/Read	⚠️ Template vars unexpanded

Overall: PASS (core connectivity verified)

cc @lpcox

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-07-09T03:56:58Z

Smoke Test: Copilot BYOK (Direct) Mode

✅ GitHub.com connectivity (HTTP 200)
✅ File write/read operations
✅ BYOK inference path (api-proxy → api.githubcopilot.com)

Status: PASS
Mode: Direct BYOK via COPILOT_PROVIDER_API_KEY

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-07-09T03:57:36Z

OTEL Tracing Smoke Test — PR #6050

Scenario	Result	Detail
1. Module Loading	✅ Pass	`otel.js` loads; exports `startRequestSpan`, `setTokenAttributes`, `setBudgetAttributes`, `endSpan`, `endSpanError`, `shutdown`, `isEnabled` + helpers. `isEnabled()` returns `true`.
2. Test Suite	✅ Pass	59 tests passed, 0 failed (2 suites: `otel.test.js`, `otel-fanout.test.js`). Covers spans, token attrs, parent context, all exporters, serialization, shutdown.
3. Env Var Forwarding	✅ Pass	`src/services/api-proxy-env-config.ts` forwards `GH_AW_OTLP_ENDPOINTS`, `OTEL_EXPORTER_OTLP_ENDPOINT`, `OTEL_EXPORTER_OTLP_HEADERS`, `GITHUB_AW_OTEL_TRACE_ID`, `GITHUB_AW_OTEL_PARENT_SPAN_ID`, `OTEL_SERVICE_NAME` to the container.
4. Token Tracker Integration	✅ Pass	`token-tracker-http.js` line 343 invokes `onUsage` callback (OTEL hook point) after normalized usage is extracted from each response.
5. OTEL Diagnostics	✅ Pass (graceful degradation)	No OTLP endpoint configured; spans fall back to `FileSpanExporter` → `/var/log/api-proxy/otel.jsonl` as expected.

All 5 scenarios pass. OTEL tracing integration is fully functional.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

Copilot AI review requested due to automatic review settings July 9, 2026 03:45

lpcox added the ready-for-aw label Jul 9, 2026

Copilot started reviewing on behalf of lpcox July 9, 2026 03:48 View session

lpcox had a problem deploying to aoai-model July 9, 2026 03:48 — with GitHub Actions Failure

Copilot AI reviewed Jul 9, 2026

View reviewed changes

github-actions Bot added the smoke-claude label Jul 9, 2026

github-actions Bot added the smoke-copilot-pat label Jul 9, 2026

lpcox temporarily deployed to aoai-model July 9, 2026 03:55 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot-byok-aoai-apikey label Jul 9, 2026

github-actions Bot added the build-test label Jul 9, 2026

lpcox merged commit 025a59e into main Jul 9, 2026
80 of 82 checks passed

github-actions Bot added the smoke-copilot-byok-aoai-entra label Jul 9, 2026

lpcox deleted the fix/workdir-setup-test-macos branch July 9, 2026 03:56

lpcox temporarily deployed to aoai-model July 9, 2026 03:56 — with GitHub Actions Inactive

github-actions Bot added the smoke-copilot label Jul 9, 2026

github-actions Bot mentioned this pull request Jul 9, 2026

[aw] No-Op Runs #5883

Open

github-actions Bot added the smoke-copilot-byok label Jul 9, 2026

Uh oh!

Conversation

lpcox commented Jul 9, 2026

Problem

Fix

Uh oh!

github-actions Bot commented Jul 9, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

github-actions Bot commented Jul 9, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Jul 9, 2026

Smoke Test: Copilot PAT Auth

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Smoke Test: Services Connectivity

Uh oh!

github-actions Bot commented Jul 9, 2026

Chroot Version Comparison Results

Uh oh!

github-actions Bot commented Jul 9, 2026

🏗️ Build Test Suite Results

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

🔬 Smoke Test Results

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading

github-actions Bot commented Jul 9, 2026 •

edited

Loading