Skip to content

[WIP] Fix agent failure issue creation by removing pre-agent denomination#20146

Merged
pelikhan merged 2 commits intomainfrom
copilot/remove-pre-agent-denomination
Mar 9, 2026
Merged

[WIP] Fix agent failure issue creation by removing pre-agent denomination#20146
pelikhan merged 2 commits intomainfrom
copilot/remove-pre-agent-denomination

Conversation

Copy link
Contributor

Copilot AI commented Mar 9, 2026

  • Remove isPreAgentFailure detection and failureStage variable from handle_agent_failure.cjs
  • Simplify issue title to always use [aw] ${workflowName} failed without stage suffix
  • Update changeset description
  • Run fmt/lint validation (passed)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…20142)

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@pelikhan pelikhan marked this pull request as ready for review March 9, 2026 02:20
Copilot AI review requested due to automatic review settings March 9, 2026 02:20
@pelikhan pelikhan merged commit 22a4849 into main Mar 9, 2026
@pelikhan pelikhan deleted the copilot/remove-pre-agent-denomination branch March 9, 2026 02:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the pre-agent failure detection logic from the handle_agent_failure.cjs script, simplifying the failure issue title to always use [aw] ${workflowName} failed without the (pre-agent) stage suffix.

Changes:

  • Removed isPreAgentFailure detection, failureStage variable, and associated comments from handle_agent_failure.cjs
  • Updated the changeset description to remove mention of labeling pre-agent failures in issue titles

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
actions/setup/js/handle_agent_failure.cjs Removed pre-agent failure detection logic and simplified issue title construction
.changeset/patch-conditional-agent-output.md Updated changeset description to remove reference to pre-agent failure labeling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

---

Make the agent-output download step conditional so `GH_AW_AGENT_OUTPUT` is only set when the artifact succeeds and label pre-agent failures in the issue title.
Make the agent-output download step conditional so `GH_AW_AGENT_OUTPUT` is only set when the artifact succeeds.
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changeset description no longer accurately describes what this PR does. It says "Make the agent-output download step conditional so GH_AW_AGENT_OUTPUT is only set when the artifact succeeds," but the actual change here is removing the pre-agent failure detection and simplifying the issue title. Consider updating the changeset description to match the actual changes, e.g., "Remove pre-agent failure detection from issue title generation to simplify failure tracking."

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants