[WIP] Fix agent failure issue creation by removing pre-agent denomination#20146
[WIP] Fix agent failure issue creation by removing pre-agent denomination#20146
Conversation
…20142) Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the pre-agent failure detection logic from the handle_agent_failure.cjs script, simplifying the failure issue title to always use [aw] ${workflowName} failed without the (pre-agent) stage suffix.
Changes:
- Removed
isPreAgentFailuredetection,failureStagevariable, and associated comments fromhandle_agent_failure.cjs - Updated the changeset description to remove mention of labeling pre-agent failures in issue titles
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
actions/setup/js/handle_agent_failure.cjs |
Removed pre-agent failure detection logic and simplified issue title construction |
.changeset/patch-conditional-agent-output.md |
Updated changeset description to remove reference to pre-agent failure labeling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| --- | ||
|
|
||
| Make the agent-output download step conditional so `GH_AW_AGENT_OUTPUT` is only set when the artifact succeeds and label pre-agent failures in the issue title. | ||
| Make the agent-output download step conditional so `GH_AW_AGENT_OUTPUT` is only set when the artifact succeeds. |
There was a problem hiding this comment.
The changeset description no longer accurately describes what this PR does. It says "Make the agent-output download step conditional so GH_AW_AGENT_OUTPUT is only set when the artifact succeeds," but the actual change here is removing the pre-agent failure detection and simplifying the issue title. Consider updating the changeset description to match the actual changes, e.g., "Remove pre-agent failure detection from issue title generation to simplify failure tracking."
isPreAgentFailuredetection andfailureStagevariable fromhandle_agent_failure.cjs[aw] ${workflowName} failedwithout stage suffix💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.