Report emitted line count in truncated patch previews - #58408
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix line count reporting in generatePatchPreview
Report emitted line count in truncated patch previews
Sep 4, 2026
Contributor
|
Category: bug | Risk: low | Score: 40 (impact 22 + urgency 10 + quality 8) | Action: defer | Batch: none
|
1 similar comment
Contributor
|
Category: bug | Risk: low | Score: 40 (impact 22 + urgency 10 + quality 8) | Action: defer | Batch: none
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The fix and regression coverage are complete with no unresolved issues.
Pull request overview
Corrects truncated patch previews to report the number of lines actually emitted.
Changes:
- Counts lines after applying both truncation limits.
- Adds regression coverage for character and line truncation.
File summaries
| File | Description |
|---|---|
actions/setup/js/create_pull_request_helpers.test.cjs |
Tests both truncation paths independently. |
actions/setup/js/create_pull_request_helpers.cjs |
Reports the final preview line count. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generatePatchPreview()reported the pre-truncation line count when the 2,000-character cap shortened a patch, producing misleading summaries such as “435 of 435 lines.”Preview summary
Regression coverage