Skip to content

chore: Pin eslint to 9.39.3 (eslint@10 incompatible with eslint-plugin-github) #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdulahmad307 merged 2 commits into from
Mar 5, 2026
+63 −157
Merged

chore: Pin eslint to 9.39.3 (eslint@10 incompatible with eslint-plugin-github) #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a872fee
Initial plan
Copilot Mar 4, 2026
ae7c6f0
chore: revert eslint to 9.39.3 for compatibility with eslint-plugin-g…
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
218 changes: 62 additions & 156 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"markdown-it": "14.1.1"
},
"devDependencies": {
"eslint": "^10.0.2",
"eslint": "^9.39.3",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title says "Pin eslint to 9.39.3", but ^9.39.3 is not a pin—it allows automatic upgrades up to (but not including) 10.0.0. If the intent is a true pin to avoid future incompatibilities, change this to "eslint": "9.39.3" (or use ~9.39.3 if you only want patch updates).

Suggested change
"eslint": "^9.39.3",
"eslint": "9.39.3",

Copilot uses AI. Check for mistakes.
"globals": "^17.0.0",
"eslint-plugin-github": "^6.0.0",
"jest": "^30.0.3",
Expand Down
Loading