Skip to content

live_stream_events_service.performLiveStreamEventAction({'xsi_type': 'ActivateLiveStreamEvents'}, <Live_Streams_List>) executed and impacted all Live Streams configs #461

Open

Description

@piyush2508

Variable Def -

Set ID of the LiveStreamEvent to get live stream events from.

LIVE_STREAM_EVENT_ID = 'INSERT_LIVE_STREAM_EVENT_ID_HERE'

Incorrect Usage -
statement = (ad_manager.StatementBuilder(version='v202002')
.Where(('Id = :id'))
.WithBindVariable('id', int(live_stream_event_id))
.Limit(500))

Considering event id is not found via statement query will return all Live Streams and accidentally causing updateLiveStreamEvents to all LiveStreams

live_stream_events = live_stream_events_service.updateLiveStreamEvents(
updated_live_stream_events)

Activity

  1. piyush2508 commented on May 11, 2020

    @piyush2508
    Author

    I re-checked, it seems the reason for this issue is not the above variable but when I executed below query:

    live_stream_events_service.performLiveStreamEventAction({'xsi_type': 'ActivateLiveStreamEvents'}, <Live_Streams_List>)

    Query executed and updated all live events in the network.

    Is there a way to avoid this? to make sure API doesn't execute if valid query/format is not passed.

  2. changed the title [-]Defined Variable not used, impacting changes to ALL LiveStreamEvents as all returned by default[/-] [+]live_stream_events_service.performLiveStreamEventAction({'xsi_type': 'ActivateLiveStreamEvents'}, <Live_Streams_List>) executed and impacted all Live Streams configs[/+] on May 11, 2020
  3. piyush2508 commented on May 11, 2020

    @piyush2508
    Author

    Expected Result: This Query should not execute.

  4. christopherseeley commented on Mar 28, 2024

    @christopherseeley
    Member

    So the request here is to validate that the parameter is able to be serialized to the xsi type rather than silently serializing as null?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions