stream pipelining - #3095
Merged
Merged
Conversation
mangas
force-pushed
the
filipe/stream-pipeline
branch
3 times, most recently
from
December 23, 2021 13:36
3d2a5ee to
0870ece
Compare
leoyvens
reviewed
Dec 23, 2021
leoyvens
left a comment
Contributor
There was a problem hiding this comment.
A more encapsulated approach which I'd suggest is to introduce a BufferedBlockStream, which takes as input a block stream and a buffer size, and returns
mangas
force-pushed
the
filipe/stream-pipeline
branch
2 times, most recently
from
December 23, 2021 17:02
1bacbbe to
72d5aaf
Compare
mangas
marked this pull request as ready for review
December 23, 2021 17:27
mangas
force-pushed
the
filipe/stream-pipeline
branch
2 times, most recently
from
December 31, 2021 00:50
e518cf7 to
abf15a3
Compare
mangas
force-pushed
the
filipe/stream-pipeline
branch
3 times, most recently
from
January 5, 2022 16:52
3f6b299 to
cc1e71a
Compare
mangas
force-pushed
the
filipe/stream-pipeline
branch
10 times, most recently
from
January 10, 2022 11:23
126af66 to
4e5652b
Compare
leoyvens
suggested changes
Jan 12, 2022
mangas
force-pushed
the
filipe/stream-pipeline
branch
2 times, most recently
from
January 13, 2022 16:28
a6013a8 to
ded67bf
Compare
leoyvens
reviewed
Jan 14, 2022
| use tokio::task; | ||
|
|
||
| const MINUTE: Duration = Duration::from_secs(60); | ||
| const BUFFERED_BLOCK_STREAM_SIZE: usize = 100; |
Contributor
There was a problem hiding this comment.
BUFFERED_POLLING_BLOCK_STREAM_SIZE would be more accurate.
leoyvens
approved these changes
Jan 14, 2022
mangas
force-pushed
the
filipe/stream-pipeline
branch
from
January 14, 2022 15:15
ded67bf to
448970a
Compare
mangas
force-pushed
the
filipe/stream-pipeline
branch
3 times, most recently
from
January 17, 2022 14:40
76f8966 to
b0802c4
Compare
leoyvens
approved these changes
Jan 17, 2022
mangas
force-pushed
the
filipe/stream-pipeline
branch
from
January 17, 2022 14:47
b0802c4 to
74cd3b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.